Soldeer compatibility / remappings issue

[PatrickAlphaC]

Is your feature request related to a problem? Please describe.
Right now, if you run aderyn on a repository that uses soldeer as it's package manager, it will fail.

Describe the solution you'd like
For aderyn to work with soldeer.

Walkthrough

git clone https://github.com/Cyfrin/2024-09-president-elector
soldeer install 
forge build
aderyn .

You will get an error because it doesn't recognize dependencies in a different folder.

[TilakMaddy]

Temporary solution:

If you remove

 [dependencies]
"@openzeppelin-contracts" = "5.0.2"

from foundry.toml and run aderyn, it will work.

[TilakMaddy]

@alexroan looks like we need to update our foundry-config fork again (not foundry-compilers-backend) because its unable to parse the dependency above and it errors out. Maybe the new updated version allows this style of having quotes around version and dependency name

Let's do it post LSP integration after EOW?

[TilakMaddy]

@PatrickAlphaC we don't assume any framework or package manager in the user's environment :) This was a config parse error from what it looks like to me ...

[TilakMaddy]

Aderyn Analysis Report

This report was generated by Aderyn, a static analysis tool built by Cyfrin, a blockchain security company. This report is not a substitute for manual audit or security review. It should not be relied upon for any purpose other than to assist in the identification of potential security vulnerabilities.

Table of Contents

• Summary
  • Files Summary
  • Files Details
  • Issue Summary
• High Issues
  • H-1: Storage Array Edited with Memory
• Low Issues
  • L-1: Loop condition contains state_variable.length that could be cached outside.
  • L-2: Costly operations inside loops.

Summary

Files Summary

Key	Value
.sol Files	1
Total nSLOC	154

Files Details

Filepath	nSLOC
src/RankedChoice.sol	154
Total	154

Issue Summary

Category	No. of Issues
High	1
Low	2

High Issues

H-1: Storage Array Edited with Memory

Storage reference is passed to a function with a memory parameter. This will not update the storage variable as expected. Consider using storage parameters instead.

3 Found Instances

• Found in src/RankedChoice.sol Line: 73

                   if (!_isInArray(s_candidateList, orderedCandidates[j])) {

• Found in src/RankedChoice.sol Line: 79

           address[] memory winnerList = _selectPresidentRecursive(

• Found in src/RankedChoice.sol Line: 167

           if (!_isInArray(VOTERS, voter)) {

Low Issues

L-1: Loop condition contains state_variable.length that could be cached outside.

Cache the lengths of storage arrays if they are used and not modified in for loops.

2 Found Instances

• Found in src/RankedChoice.sol Line: 68

           for (uint256 i = 0; i < VOTERS.length; i++) {

• Found in src/RankedChoice.sol Line: 107

           for (uint256 i = 0; i < VOTERS.length; i++) {

L-2: Costly operations inside loops.

Invoking SSTOREoperations in loops may lead to Out-of-gas errors. Use a local variable to hold the loop computation result.

4 Found Instances

• Found in src/RankedChoice.sol Line: 68

           for (uint256 i = 0; i < VOTERS.length; i++) {

• Found in src/RankedChoice.sol Line: 72

               for (uint256 j = 0; j < orderedCandidates.length; j++) {

• Found in src/RankedChoice.sol Line: 107

           for (uint256 i = 0; i < VOTERS.length; i++) {

• Found in src/RankedChoice.sol Line: 108

               for (

[PatrickAlphaC]

Nice! Ok so... is this going to stay an issue then?

[TilakMaddy]

Yes sir! Until we parse the config properly its going to remain an open issue

[TilakMaddy]

GM @PatrickAlphaC ! Finally solved in 0.5.4 .I've verified it 🙌

[PatrickAlphaC]

lfg!