feat: Add mimetype detection for rich text format (rtf) #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com>
jkowalleck
approved these changes
Apr 24, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
this was released via https://github.com/CycloneDX/cyclonedx-python/releases/tag/v6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mimetype for the Rich Text Format (RTF).
The format is 7-Bit ASCII safe, so automatically passes basic checks for UTF-8. But with all its custom tags and escape sequences it formally is closer to a binary format.
So we use the application/rtf mimetype instead of the also possible text/rtf mimetype, as most consumers will consider this to be binary.
This overrides the misdetection by the stdlib, which claims RTF to be associated with application/msword.