BC: v4.0.0 #589
Open
BC: v4.0.0 #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
### Description
* BREAKING changes
* Removed deprecated symbols
* Changed constructor of
`CycloneDX\Contrib\License\Factories\LicenseFactory`
* Removed
* `CycloneDX\Core\Factories\LicenseFactory`
Use `\CycloneDX\Contrib\License\Factories\LicenseFactory` instead.
* `CycloneDX\Core\Utils\BomUtility`
Use `\CycloneDX\Contrib\Bom\Utils\BomUtils` instead.
* Changed
* `CycloneDX\Contrib\License\Factories\LicenseFactory::__construct()`
parameters are no longer autopopulated
Downstream implementations have to populate the parameters on their own,
now.
* Dependencies
* No longer depends on, but suggests `composer/spdx-licenses:^1.5`
May be used when utilizing
`\CycloneDX\Contrib\License\Factories\LicenseFactory`.
part of #571
---------
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
added
dependencies
### Description * BREAKING changes * Changed dependencies * Changed properties `packageUrl` * Changed * `CycloneDX\Core\Models\Component::setPackageUrl()` accepts `?string` Downstream implementations may use [package-url/packageurl-php](https://packagist.org/packages/package-url/packageurl-php) for generation. * `CycloneDX\Core\Models\Component::getPackageUrl()` returns `?string` Downstream implementations may use [package-url/packageurl-php](https://packagist.org/packages/package-url/packageurl-php) for parsing. * Dependencies * No longer depend on `package-url/packageurl-php` part of #571 --------- Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
You can expedite processing of your PR by using this template to provide
context
and additional information. Before actually opening a PR please make
sure that it
does NOT fall into any of the following categories
🚫 Spam PRs (accidental or intentional) - these will result in a 30-days
or even
∞ ban from interacting with the project depending on reoccurrence and
severity.
🚫 Lazy typo fixing PRs - if you fix a typo in a file, your PR will only
be merged
if all other typos in the same file are also fixed with the same PR
🚫 If you fail to provide any _Description_ below, your PR will be
considered spam.
If you do not check the _Affirmation_ box below, your PR will not be
merged.
🚫 If you do not check one of the _AI Tool Disclosure_ boxes below, your
PR will
not be merged. If you used AI tools to assist you in writing code, but
fail to
provide the required disclosure, your PR will not be merged.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
### Description
<!-- ✍️-->
* `CycloneDX\Core\Validation\BaseValidator::__construct()` parameter is
type `CycloneDX\Core\Spec\Version`
Was internal type `CycloneDX\Core\Spec\_SpecProtocol`.
Resolves or fixes issue: #590
### AI Tool Disclosure
- [x] My contribution does not include any AI-generated content
- [ ] My contribution includes AI-generated content, as disclosed below:
- AI Tools: `[e.g. GitHub CoPilot, ChatGPT, JetBrains Junie etc.]`
- LLMs and versions: `[e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro
etc.]`
- Prompts: `[Summarize the key prompts or instructions given to the AI
tools]`
### Affirmation
- [x] My code follows the
[CONTRIBUTING.md](https://github.com/CycloneDX/cyclonedx-php-library/blob/master/CONTRIBUTING.md)
guidelines
---------
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/CycloneDX/cyclonedx-php-library/milestone/4
CycloneDX\Contrib\License\Factories\LicenseFactoryCycloneDX\Core\Factories\LicenseFactoryUse
CycloneDX\Contrib\License\Factories\LicenseFactoryinstead.CycloneDX\Core\Utils\BomUtilityUse
CycloneDX\Contrib\Bom\Utils\BomUtilsinstead.CycloneDX\Core\Validation\BaseValidator::getSpec()CycloneDX\Contrib\License\Factories\LicenseFactory::__construct()parameters are no longer autopopulatedDownstream implementations have to populate the parameters on their own, now.
CycloneDX\Core\Models\Component::setPackageUrl()accepts?stringDownstream implementations may use package-url/packageurl-php for generation.
CycloneDX\Core\Models\Component::getPackageUrl()returns?stringDownstream implementations may use package-url/packageurl-php for parsing.
CycloneDX\Core\Validation\BaseValidator::__construct()parameter is typeCycloneDX\Core\Spec\VersionWas internal type
CycloneDX\Core\Spec\_SpecProtocol.composer/spdx-licenses:^1.5May be used when utilizing
CycloneDX\Contrib\License\Factories\LicenseFactory.package-url/packageurl-php