feat: add npm engine constraint properties - #1507
Merged
jkowalleck merged 5 commits intoAug 17, 2026
Merged
Conversation
Populate CycloneDX npm taxonomy properties from package.json engine constraints and ignore malformed non-string values. Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Documentation build overview
|
jkowalleck
requested changes
Aug 14, 2026
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com> Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Contributor
Author
|
Both review requests are now in place at exact head
Verification on this head: 8 focused ComponentBuilder tests, 4,155 full node tests, Thanks for the review and for applying the HISTORY.md suggestion. |
…malformed engines Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
CAOShurong
force-pushed
the
codex/1506-node-engine-constraints
branch
from
August 15, 2026 04:21
dee02ea to
e328805
Compare
jkowalleck
approved these changes
Aug 17, 2026
2 tasks
jkowalleck
approved these changes
Aug 17, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Populate
Component.propertiesfrom the string-valued entries in a Nodepackage manifest's
enginesobject. Each entry uses the existing CycloneDXnpm property taxonomy name
cdx:npm:package:constraint:engine:<name>.Malformed non-string engine constraints are ignored, consistent with the
builder's defensive handling of other package manifest fields.
Fixes issue: #1506
Verification
npm run test:node(4,166 passing)npm run test:lintnpm run test:standardnpm run test:dependenciesnpm run build:nodenpm run build:webnpx tsc -b ./tsconfig.d.jsonnpm pack --ignore-scripts, followed by installation into a clean directoryand runtime checks for valid constraints, malformed values, and a missing
package name
AI Tool Disclosure
OpenAI CodexGPT-5Inspect issue #1506 and the repository contribution rules; implement only the required npm engine constraint properties; add positive and malformed-input regression coverage; run build, lint, full tests, package, and clean-install runtime verification.Affirmation