Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode quotation mark in URLs #1155

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Oct 24, 2024

fixes #1154

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label Oct 24, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner October 24, 2024 09:39
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Copy link

codacy-production bot commented Oct 24, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bdbe727) 23736 23350 98.37%
Head commit (2da04e7) 23742 (+6) 23356 (+6) 98.37% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1155) 7 7 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title fix: iri-escape double-quot fix: escape quotation mark in URLs Oct 24, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title fix: escape quotation mark in URLs fix: encode quotation mark in URLs Oct 24, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit d559aa3 into main Oct 24, 2024
43 checks passed
@jkowalleck jkowalleck deleted the fix/iri-reference_doublequot branch October 24, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] URL with quotation marks violates XML schema
1 participant