Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #44

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Bugfix #44

merged 1 commit into from
Feb 26, 2021

Conversation

cccs-gm
Copy link
Contributor

@cccs-gm cccs-gm commented Feb 26, 2021

  • YaraFileProcessor.__replace_for_each_one_to_many() did not handle lines with only spaces or tabs well. Since the non_white_space_index only got set higher then 0 if a non_white_space character
    was found likes without spaces or tabs would double in size.
  • Added a check, if non_white_space_index == 0 then set it to the lenghth of the line.

- YaraFileProcessor.__replace_for_each_one_to_many() did not handle lines with only spaces or tabs well. Since the non_white_space_index only got set higher then 0 if a non_white_space character
was found likes without spaces or tabs would double in size.
- Added a check, if non_white_space_index == 0 then set it to the lenghth of the line.
@cccs-gm cccs-gm requested a review from cccs-jp February 26, 2021 13:16
Copy link

@cccs-kevin cccs-kevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cccs-gm cccs-gm merged commit 7c94d0e into master Feb 26, 2021
@cccs-gm cccs-gm deleted the bugfix_doubling_space_forever branch February 26, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants