Skip to content

Conversation

@ALPHAAAL
Copy link
Contributor

@ALPHAAAL ALPHAAAL commented Jul 15, 2025

Just thought that this is a nice filter to have since sometimes when importing files it contains both JPEG and raws.

Screenshot of the change:
image

@ALPHAAAL
Copy link
Contributor Author

Found out this issue, kind of related
#75

@ALPHAAAL ALPHAAAL marked this pull request as draft July 15, 2025 11:41
@ALPHAAAL ALPHAAAL marked this pull request as ready for review July 15, 2025 11:45
@CyberTimon
Copy link
Owner

Thanks for the PR, @ALPHAAAL! These are very useful filter additions 💯

I've noticed a technical issue with the 'edited/unedited' filter. The is_edited status is only determined when the folder is first loaded and doesn't update when a user makes or resets edits. This causes the filter to become inaccurate.

For that reason, I'll be removing the edited/unedited filter for now. The RAW / Non-RAW filtering is a solid addition, and I'll merge that part of the change.

If you can find a good solution for updating the is_edited state accurate, I'd be happy to review and merge that functionality as well.

P.S. I also updated the has_sidecar_adjustments check in the backend. I'm leaving this improved functionality in place as it will be useful for future filtering.

Thanks again for the contribution :)

@CyberTimon CyberTimon merged commit 3cd15ef into CyberTimon:main Jul 15, 2025
@ALPHAAAL
Copy link
Contributor Author

Hey @CyberTimon, thanks for the review and you have a great point! Let me get back to this later 👍

@william-sy
Copy link
Contributor

Related issue: #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants