Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Apr 1, 2018

This would make the backend conversion a little easier as 2.068 and higher doesn't generate a new assert template everytime it's generated.

See also:

@CyberShadow
Copy link
Owner

This needs to be made conditional, otherwise bootstrapping from source won't work.

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 2, 2018

Why? I thought 2.068.2 is the last C++ release?

@CyberShadow
Copy link
Owner

No. 2.068.2 already had idgen.d.

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 2, 2018

Argh sorry. I didn't know that. What do you propose then?
For now I think this would only be needed for DAutoTest, but I guess as soon as Walter starts using assert in the "betterC" backend, it will affect digger too...

@CyberShadow
Copy link
Owner

If we decide that we want to add another step to the from-source bootstrap process, then we can do that. But it needs to be an informed decision.

See my older comments on the previous iteration of that PR: dlang/dmd#6907 (comment)

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 2, 2018

I thought this has already been discussed and approved?

https://forum.dlang.org/post/zbxaviowooiaenaawmgs@forum.dlang.org

We've been through bootstrapping discussions a couple of times, so let me repeat what was decided when we made the frontend switch from C++ to D.

  • Other platforms are bootstrapped by cross-compilation.
  • DMD must be compilable with the latest stable/major release of dmd, ldc, and gdc.

To enforce this policy the Travis-CI test was set up.
Hopefully this original purpose of the Travis-CI hasn't been forgotten in the meantime.

  • No other guarantees were negotiated.

@CyberShadow
Copy link
Owner

Ah, OK. I didn't see that discussion.

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 2, 2018

Seems like there's a new discussion going on -> dlang/dmd#8112

@CyberShadow
Copy link
Owner

This still needs to be made conditional, otherwise this change will break bootstrapping from source (which is a Digger feature), and more importantly, building DMD versions between 2.067.1 and 2.068.2 will no longer work (incl. bisecting commits in that range).

@CyberShadow
Copy link
Owner

@wilzbach Do you want to do the changes?

@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 4, 2018

Ehm I think it will be a lot faster if you do the needed changes by yourself (there's a lot of code that I never seen/touched).
Also note that according to dlang/dmd#8112 the new minimal host compiler should be 2.074

@wilzbach wilzbach closed this Apr 4, 2018
@CyberShadow
Copy link
Owner

Fine by me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants