- 
                Notifications
    You must be signed in to change notification settings 
- Fork 39
Bump default dmdVer to 2.068.2 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| This needs to be made conditional, otherwise bootstrapping from source won't work. | 
| Why? I thought 2.068.2 is the last C++ release? | 
| No. 2.068.2 already had  | 
| Argh sorry. I didn't know that. What do you propose then? | 
| If we decide that we want to add another step to the from-source bootstrap process, then we can do that. But it needs to be an informed decision. See my older comments on the previous iteration of that PR: dlang/dmd#6907 (comment) | 
| I thought this has already been discussed and approved? https://forum.dlang.org/post/zbxaviowooiaenaawmgs@forum.dlang.org 
 
 
 | 
| Ah, OK. I didn't see that discussion. | 
| Seems like there's a new discussion going on -> dlang/dmd#8112 | 
| This still needs to be made conditional, otherwise this change will break bootstrapping from source (which is a Digger feature), and more importantly, building DMD versions between 2.067.1 and 2.068.2 will no longer work (incl. bisecting commits in that range). | 
| @wilzbach Do you want to do the changes? | 
| Ehm I think it will be a lot faster if you do the needed changes by yourself (there's a lot of code that I never seen/touched). | 
| Fine by me, thanks. | 
This would make the backend conversion a little easier as 2.068 and higher doesn't generate a new
asserttemplate everytime it's generated.See also: