feat(config): Allow Scoop to ignore running processes during reset/un…

…install/update (ScoopInstaller#4713)

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

CHANGELOG.md

@@ -3,6 +3,7 @@
 
 ### Features
 
+- **config:** Allow Scoop to ignore running processes during reset/uninstall/update ([#4713](https://github.com/ScoopInstaller/Scoop/issues/4713))
 - **scoop-download:** Add `scoop download` command ([#4621](https://github.com/ScoopInstaller/Scoop/issues/4621))
 - **scoop-(install|virustotal):** Allow skipping update check ([#4634](https://github.com/ScoopInstaller/Scoop/issues/4634))
 - **scoop-bucket:** List more detailed information for buckets ([#4704](https://github.com/ScoopInstaller/Scoop/pull/4704))

lib/install.ps1

@@ -1211,3 +1211,17 @@ function persist_permission($manifest, $global) {
         $acl | Set-Acl -Path $path
     }
 }
+
+# test if there are running processes
+function test_running_process($app, $global) {
+    $processdir = appdir $app $global | Convert-Path
+    $running_processes = Get-Process | Where-Object { $_.Path -like "$processdir\*" }
+
+    if ($running_processes -and !(get_config 'ignore_running_processes')) {
+        error "Application `"$app`" is still running. Close all instances and try again."
+        return $true
+    } else {
+        warn "Application `"$app`" is still running. Scoop is configured to ignore this condition."
+        return $false
+    }
+}

libexec/scoop-config.ps1

@@ -81,6 +81,11 @@
 #       API key used for uploading/scanning files using virustotal.
 #       See: 'https://support.virustotal.com/hc/en-us/articles/115002088769-Please-give-me-an-API-key'
 #
+# ignore_running_processes: $true|$false
+#       When set to $false (default), Scoop would stop its procedure immediately if it detects
+#       any target app process is running. Procedure here refers to reset/uninstall/update.
+#       When set to $true, Scoop only displays a warning message and continues procedure.
+#
 # ARIA2 configuration
 # -------------------
 #

libexec/scoop-reset.ps1

@@ -68,9 +68,7 @@ $apps | ForEach-Object {
     $persist_dir = persistdir $app $global
 
     #region Workaround for #2952
-    $processdir = $dir | Select-Object -ExpandProperty Path
-    if (Get-Process | Where-Object { $_.Path -like "$processdir\*" }) {
-        error "Application is still running. Close all instances and try again."
+    if (test_running_process $app $global) {
         continue
     }
     #endregion Workaround for #2952

libexec/scoop-uninstall.ps1

@@ -59,9 +59,7 @@ if (!$apps) { exit 0 }
         $persist_dir = persistdir $app $global
 
         #region Workaround for #2952
-        $processdir = $appDir | Resolve-Path | Select-Object -ExpandProperty Path
-        if (Get-Process | Where-Object { $_.Path -like "$processdir\*" }) {
-            error 'Application is still running. Close all instances and try again.'
+        if (test_running_process $app $global) {
             continue
         }
         #endregion Workaround for #2952

libexec/scoop-update.ps1

@@ -231,9 +231,7 @@ function update($app, $global, $quiet = $false, $independent, $suggested, $use_c
     $persist_dir = persistdir $app $global
 
     #region Workaround for #2952
-    $processdir = appdir $app $global | Resolve-Path | Select-Object -ExpandProperty Path
-    if (Get-Process | Where-Object { $_.Path -like "$processdir\*" }) {
-        error "Application is still running. Close all instances and try again."
+    if (test_running_process $app $global) {
         return
     }
     #endregion Workaround for #2952