Skip to content

Settings context #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Adakar merged 11 commits into from
Apr 24, 2023
Merged

Settings context #7

Adakar merged 11 commits into from
Apr 24, 2023

Conversation

@pawtom
Copy link
Contributor

@pawtom pawtom commented Apr 18, 2023 •
edited
Loading

A new module for using different Squish testSettings as context manager.

with settings.logScreenshotOnFail(True), settings.logScreenshotOnPass(True):
        test.passes("aaa")   
        test.fail("bbb")

@pawtom pawtom requested a review from Adakar April 18, 2023 10:02
Adakar
Adakar requested changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@Adakar Adakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about setting default values for parameters? At least for some of the functions.

Adakar
Adakar reviewed Apr 21, 2023
View reviewed changes
Adakar
Adakar requested changes Apr 21, 2023
View reviewed changes
@pawtom pawtom requested a review from Adakar April 24, 2023 10:31
@Adakar Adakar merged commit 7ef6ae4 into main Apr 24, 2023
@Adakar Adakar deleted the settings_context branch May 17, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Adakar Adakar Adakar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawtom @Adakar