Skip to content

add the ability to add spaces and conver images at the same times, and undo function. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaxinandye
Copy link

@xiaxinandye xiaxinandye commented Jan 1, 2019

@CyC2018
Copy link
Owner

CyC2018 commented Jan 1, 2019

@xiaxinandye undo 功能太不明显了

@xiaxinandye
Copy link
Author

@CyC2018 重点是同时添加空格和转换图片,我对前端不是很了解,我认为undo操作使用性本来就不高,所以要使用的undo功能的人也能发现如何使用,不需要使用的undo人,也不需要知道,您觉得呢?

@CyC2018
Copy link
Owner

CyC2018 commented Jan 2, 2019

@xiaxinandye 那个 undo 操作完全没必要。。而且你这个 undo 和我想的还不一样,我之前也打算添加 undo 功能,可以将转换后的 html 图片转换回原来的 markdown 图片,你这个直接是将 input 的内容替换掉 output,感觉没多少意义。同时添加空格和转换图片功能,可以单独再加一个一键转换的按钮,因为也有人只想用其中一个功能。

@xiaxinandye
Copy link
Author

@CyC2018 你说的有道理,我这个undo功能是根据我自己的情况开发的,undo我考虑的是空格方面,所以不能又将数字和中文之间的空格都取消噻?关于图片再逆转换格式的话,我用不上,所以undo功能没有思考过这一点,那还是依照你来吧。。。

@CyC2018
Copy link
Owner

CyC2018 commented Jan 2, 2019

@xiaxinandye 我是说你这个 undo 没用,原始数据就在左边。

@xiaxinandye
Copy link
Author

@CyC2018 嗯,作用是不大,只要有同时进行空格和图片的转换功能就行了。

@CyC2018
Copy link
Owner

CyC2018 commented Jan 2, 2019

@xiaxinandye 那你可以再添加一个按钮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants