addons: vxlan: local-tunnelip can be an ipv6 #172
Conversation
|
Hi @JackSlateur For this we would need a new attribute See 4065833 where I added new ipv6 attributes (ideally we wouldn't duplicate existing code like i had to do, i was in a rush when i added those attributes). |
Signed-off-by: Alexandre Bruyelles <abruyelles@odiso.com>
|
@julienfortin Indeed :) I've reworked -and tested- the code, with a single user-facing parameter Please note that #173 is required Thank you for the review |
There was a problem hiding this comment.
Hi @JackSlateur, we still need to have a specific attribute for ipv6. We don't want to have both mixed-up within the same attribute.
I left some comments on your commit, basically the function __config_vxlan_local_tunnelip needs to be reworked a bit.
| @@ -47,7 +47,7 @@ class vxlan(Addon, moduleBase): | |||
| }, | |||
| "vxlan-local-tunnelip": { | |||
| "help": "vxlan local tunnel ip", | |||
| "validvals": ["<ipv4>"], | |||
| "validvals": ["<ipv4>, <ipv6>"], | |||
| "example": ["vxlan-local-tunnelip 172.16.20.103"] | |||
| }, | |||
There was a problem hiding this comment.
We shouldn't add ipv6 to this attribute but add a new attribute vxlan-local-tunnelip6
| @@ -393,7 +393,7 @@ def __config_vxlan_local_tunnelip(self, ifname, ifaceobj, link_exists, user_requ | |||
| if link_exists: | |||
| # on ifreload do not overwrite anycast_ip to individual ip | |||
| # if clagd has modified | |||
| running_localtunnelip = cached_vxlan_ifla_info_data.get(Link.IFLA_VXLAN_LOCAL) | |||
There was a problem hiding this comment.
The function __config_vxlan_local_tunnelip should be reworked so that it handles both vxlan-local-tunnelip and vxlan-local-tunnelip6.
It could take the NETLINK_ATTR id as parameter (Link.IFLA_VXLAN_LOCAL or Link.IFLA_VXLAN_LOCAL6), as well as the attribute name so that no other changes are needed (this is what i should have done for mcastgrp6).
|
Ok I'm closing this, I'll possibly rework the code as you asked and reopen then Thank you for the review |
iproute2 as well as the kernel supports vxlan over IPv6
Signed-off-by: Alexandre Bruyelles abruyelles@odiso.com