-
Notifications
You must be signed in to change notification settings - Fork 26
Update branding documentation to reflect changes fixes done on MTM-65244 #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlosceia
wants to merge
4
commits into
develop
Choose a base branch
from
feat/update-branding-documentation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview available here |
BeateRixen
reviewed
Nov 21, 2025
content/web/application-configuration-bundle/branding-your-application.md
Outdated
Show resolved
Hide resolved
content/web/application-configuration-bundle/branding-your-application.md
Outdated
Show resolved
Hide resolved
content/web/application-configuration-bundle/branding-your-application.md
Outdated
Show resolved
Hide resolved
content/web/application-configuration-bundle/branding-your-application.md
Outdated
Show resolved
Hide resolved
| ``` | ||
|
|
||
| {{< c8y-admon-important >}} | ||
| **Import order is critical:** Always import `@c8y/style/extend.less` **FIRST** at the top of your file, then override variables AFTER. This ensures the conditional guard system can detect your overrides correctly. |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| **Import order is critical:** Always import `@c8y/style/extend.less` **FIRST** at the top of your file, then override variables AFTER. This ensures the conditional guard system can detect your overrides correctly. | |
| **Import order is critical:** Always import `@c8y/style/extend.less` **first** at the top of your file, then override variables **after**. This ensures the conditional guard system can detect your overrides correctly. |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the highlighting in several cases. One method, either all caps or bold, is enough :-).
content/web/application-configuration-bundle/branding-your-application.md
Outdated
Show resolved
Hide resolved
content/web/application-configuration-bundle/branding-your-application.md
Outdated
Show resolved
Hide resolved
content/web/application-configuration-bundle/branding-your-application.md
Outdated
Show resolved
Hide resolved
minor language edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated branding documentation across 4 files to emphasize CSS variables with the branding editor as the recommended approach, deprecated
brandingEntry, and added Angular 18 migration guidance.Changes
branding-your-application.md
brandingEntryreferencesapplication-options.md
brandingEntryfrom flavor configuration exampleangular.jsonconfiguration for flavor-specific brandingupgrading-to-angular-18.md
brandingEntrydeprecation noticec8y-cli.md
--app.brandingEntryCLI flagstylesconfiguration insteadImpact
Related
This complements the technical fixes in the
cumulocity-uirepository (https://github.com/Cumulocity-IoT/cumulocity-ui/pull/10345) that enable LESS variable customization to work correctly.