Skip to content

MTM-62651 Added release notes for withChildren default value change #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

pkepa-c8y
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Preview available here

…TM-62651_default-value-for-the-inventory-withChildren-parameter.md
Copy link
Contributor

@JanePorter JanePorter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@pkepa-c8y
Copy link
Contributor Author

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@JanePorter Yes it is. It was announced in https://drive.google.com/file/d/1vukBH7i_8yT-lLcH41k_zYoVdeFArlTs/view?usp=sharing.

@BeateRixen
Copy link
Collaborator

BeateRixen commented Apr 2, 2025

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@JanePorter Yes it is. It was announced in https://drive.google.com/file/d/1vukBH7i_8yT-lLcH41k_zYoVdeFArlTs/view?usp=sharing.

…TM-62651_default-value-for-the-inventory-withChildren-parameter.md
@BeateRixen
Copy link
Collaborator

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@JanePorter Yes it is. It was announced in https://drive.google.com/file/d/1vukBH7i_8yT-lLcH41k_zYoVdeFArlTs/view?usp=sharing.

@pkepa-c8y Please change the type to API change then.

@pkepa-c8y
Copy link
Contributor Author

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@JanePorter Yes it is. It was announced in https://drive.google.com/file/d/1vukBH7i_8yT-lLcH41k_zYoVdeFArlTs/view?usp=sharing.

@pkepa-c8y Please change the type to API change then.

@BeateRixen there is lable:

component:
  - value: component-JlFdtOPva
    label: Rest API

whet else need to be changed ?

@BeateRixen
Copy link
Collaborator

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@JanePorter Yes it is. It was announced in https://drive.google.com/file/d/1vukBH7i_8yT-lLcH41k_zYoVdeFArlTs/view?usp=sharing.

@pkepa-c8y Please change the type to API change then.

@BeateRixen there is lable:

component:
  - value: component-JlFdtOPva
    label: Rest API

whet else need to be changed ?

The change type should be "API change" instead of

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@JanePorter Yes it is. It was announced in https://drive.google.com/file/d/1vukBH7i_8yT-lLcH41k_zYoVdeFArlTs/view?usp=sharing.

@pkepa-c8y Please change the type to API change then.

@BeateRixen there is lable:

component:
  - value: component-JlFdtOPva
    label: Rest API

whet else need to be changed ?

This is a breaking change, can we making it more obvious in the Change Log? Will this go into API Change?

@JanePorter Yes it is. It was announced in https://drive.google.com/file/d/1vukBH7i_8yT-lLcH41k_zYoVdeFArlTs/view?usp=sharing.

@pkepa-c8y Please change the type to API change then.

@BeateRixen there is lable:

component:
  - value: component-JlFdtOPva
    label: Rest API

whet else need to be changed ?

The change type should be API change" instead of fix. Just done.

…TM-62651_default-value-for-the-inventory-withChildren-parameter.md

Co-authored-by: Dariusz Kaczyński <100694039+kaczynskid-sag@users.noreply.github.com>
@pkepa-c8y pkepa-c8y requested a review from JanePorter April 3, 2025 08:09
Copy link
Contributor

@JanePorter JanePorter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per a conversation with the R&D team we will be holding off this change until we have been able to get further feedback on the impact to our own UI and the customer's custom UIs

@pkepa-c8y pkepa-c8y requested a review from BeateRixen April 7, 2025 12:14
@BeateRixen
Copy link
Collaborator

@pkepa-c8y What is actually the status of this change? Still on hold?

@pkepa-c8y
Copy link
Contributor Author

@pkepa-c8y What is actually the status of this change? Still on hold?

@BeateRixen Yes, there is still no decision whether we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants