Update cookies.js for use in latest versions of pptr #78 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2022
smashah
changed the title
the-odev
approved these changes
Jun 27, 2022
quibaritaenperdresatrompe
approved these changes
Jul 12, 2022
|
Merge? |
You don't need to wait for the merge to use the patch. Add the line below to package.json:
|
|
thanks @ThinhVu I have merged the patch to the main branch on my fork's repo so you can also do this now: "puppeteer-page-proxy": "smashah/puppeteer-page-proxy"Just F.Y.I, feel free to make a PR on smashah/puppeteer-page-proxy I will try to review quickly and merge if relevant. |
|
wish this PR counld merge early. |
Oh. I don't even know that we can use that short form. Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to #78