Adding timer format #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crystalwarrior
requested changes
May 14, 2024
Owner
Crystalwarrior
left a comment
Crystalwarrior
left a comment
There was a problem hiding this comment.
Good stuff, just parse the arguments in packet_distribution rather than courtroom
src/courtroom.cpp
Outdated
| ui_rp_clock->show(); | ||
| } | ||
|
|
||
| void Courtroom::format_clock(QStringList time_format) { |
Owner
There was a problem hiding this comment.
Why is this function responsible for parsing the arguments? Pass the arguments here and handle the QStringList unpacking in packet_distribution.cpp
src/packet_distribution.cpp
Outdated
| } | ||
| else if (header == "TF") { | ||
| if (courtroom_constructed && f_contents.size() > 1) { | ||
| QStringList time_format = f_contents; |
Owner
There was a problem hiding this comment.
Break this up into arguments and pass it to format_clock instead of doing it in format_clock
Collaborator
Author
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.