iOS10 Support?

[briananderson1222]

Curious if anyone has looked into iOS 10 support for this plugin.

I tested this out for the first time today and I am seeing this error when calling cordovaSecureStorage.set

message: "Failure in SecureStorage.set() - errSecDefault"

I will continue looking into this to see if I can find more information and will pass along any findings

EDIT: This seems to affect all setting and fetching

[briananderson1222]

Apparently going into Compatibility Settings and enabling Keychain Sharing 'fixes' the issue. Haven't been doing iOS specific development for a while now so hoping that bringing this up might shed some light..

EDIT: From talking to some iOS Dev friends apparently there haven't really even been much in the way of changes when it comes to the keychain for iOS10. It looks like the SAMKeychain plugin is being used under the hood so it's possible the error is stemming from something in that plugin

EDIT2: So it looks like this plugin is using a year old version of this plugin.. maybe that has something to do with the lack of iOS10 support.. Going to see what happens if I pull in more up to date files from that plugin

EDIT3: That's a no go on pulling in the latest from that plugin. Would love to get some eyes on this since the iOS10 release is coming up soon @ggozad

[ggozad]

Hey @briananderson1222!
I haven't had a chance to look into this. I would really appreciate it if you do continue... Would you be able to make a branch updating the plugin so that I can have a look as well?

[ggozad]

Also note soffes/SAMKeychain#149

[briananderson1222]

@ggozad Is there a reason the SAMKeychain code is so out of date? Also, is there a reason that 'SAM' is renamed to 'SS' or was this what the library used a year ago when this code was last updated?

[ggozad]

@briananderson1222 indeed SSKeychain apparently became SAMKeychain. There's no particular reason, SSKeychain was more or less a sane simple API around keychain which is why it was used.

[briananderson1222]

@ggozad Okay thanks for the background information. I'll continue looking into this as time allows and open a PR if I can get it working. Let me know if there is any other background information that may be useful

[briananderson1222]

soffes/SAMKeychain#52

https://openradar.appspot.com/27844971

[briananderson1222]

I've made the upgrade to the latest version if you would like me to put up a PR for that.. unfortunately doesn't seem to fix the underlying Keychain issue on iOS10

[ggozad]

Doomsday has come and gone. All seems fine here, did you encounter any trouble?

[ggozad]

@briananderson1222 closing this as everything seems fine on iOS 10. If you do encounter any problems let me know and will reopen.

[fmhun]

Hi @ggozad, @briananderson1222

I still encountering a similar issue on iphone 7 simulator (iOS 10), with Xcode version 8.0 (8A218a) and lastest plugin version from git master branch.

The ss.set() method returns the following error :

message: "Failure in SecureStorage.set() - Refer to SecBase.h for description"

Are you experiencing the same issue ?

[ggozad]

Hey @fmhun /cc @briananderson1222
I am not sure what to take from this.
Tests all pass just fine on a real device, at least on my iphone 6 running ios 10.
Tests fail on emulator both on iphone 7 and 6.

We deployed the latest release successfully on our own app and have had no problems reported so far.
This indicates that the problem is with the emulators, but of course I would like to resolve it altogether.

Would appreciate verification of tests passing on different physical devices.