Skip to content

Updating Snapshot test to fix update errors #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

caitlinstrong
Copy link
Contributor

@caitlinstrong caitlinstrong commented Apr 15, 2025

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • [ X ] Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • [ X ] Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

The kubernetes-k3d job randomly fails when updating the status on objects during the TestReconcileDedicatedSnapshotVolume test.

Linear: PGO-2233

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

I've changed r.apply to r.Client.Create to get us past the error when the GH actions run.

@caitlinstrong caitlinstrong self-assigned this Apr 15, 2025
@caitlinstrong caitlinstrong changed the title r.Client.Create test Updating Snapshot test to fix update errors Apr 15, 2025
@caitlinstrong caitlinstrong marked this pull request as ready for review April 22, 2025 15:18
@caitlinstrong caitlinstrong marked this pull request as draft April 22, 2025 16:32
@caitlinstrong caitlinstrong marked this pull request as ready for review April 25, 2025 21:23
Copy link
Contributor

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you squash before merging.

@caitlinstrong caitlinstrong merged commit 7383f6b into CrunchyData:main Apr 30, 2025
19 checks passed
@caitlinstrong caitlinstrong deleted the snapshot-test branch April 30, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants