Skip to content

Added support for Affinity and Tolerations #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dan0x54
Copy link

@Dan0x54 Dan0x54 commented Apr 28, 2025

This will add support for tolerations and affinity as requested in #242.

@benjaminjb
Copy link
Contributor

This seems reasonable to me, though I tend to prefer the if ... end style of dropping fields if blank. What do you think of making that change?

I'm also wary of having our kustomize and Helm installations drift too far apart, but let me talk it out for a moment if we make this change:

  • If I'm a Helm chart user who wants affinity on my PGO installation, I would add values to an installation (either through the command line or by downloading the chart and making the changes -- basically, through changing the values.yaml)
  • If I'm a kustomize user who wants affinity, I download the kustomize files and change the manager.yaml file directly (or maybe add an overlay/patch to the kustomization.yaml)

Which is the same way we handle, say, resources. OK, I've talked myself into this being a Helm-only change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants