Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a stat panel showing the pod type to Pod Details. Implements #389 #390

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

gricey432
Copy link
Contributor

Description

See #389 for feature details.

Add a stat panel showing the pod type to Pod Details. Aids debugging system issues by indicating if the pod you're looking at is the write node / a replica.

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #389

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • SLES
  • Not applicable

If your code touches postgres_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4
Copy link
Collaborator

keithf4 commented Jan 11, 2024

Thanks for your work on the dashboard. We're working on a release to come out in the near future and will look at adding this to the release following that one.

@keithf4 keithf4 self-assigned this Jan 11, 2024
@keithf4 keithf4 added the FEATURE New feature or request label Jan 11, 2024
@keithf4 keithf4 added this to the 5.0 milestone Jan 11, 2024
@keithf4 keithf4 merged commit a1709fa into CrunchyData:development Feb 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show if pod is currently a master/replica on pod details
6 participants