Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgBackRest 2.52.1 breaks some backrest monitoring #420

Closed
keithf4 opened this issue Jul 25, 2024 · 0 comments · Fixed by #421
Closed

pgBackRest 2.52.1 breaks some backrest monitoring #420

keithf4 opened this issue Jul 25, 2024 · 0 comments · Fixed by #421
Assignees
Labels
BUG Something isn't working
Milestone

Comments

@keithf4
Copy link
Collaborator

keithf4 commented Jul 25, 2024

Describe the issue:

When monitoring pgBackRest version 2.52.1 (or any other version of backrest that has 3 digits in the version, but this is the only one so far), alerts will be raised for exporter scrape errors and in system logs. Also the pgBackRest grafana dashboard may also break since the informational metrics it uses are no longer available. Metrics for monitoring the backups themselves have not been affected by this issue, so alerting for failed backups should not be affected.

If users are on versions less than 2.52, this does not affect them. Upgrading to the latest version of pgBackRest 2.53 will also correct this issue.

sql_exporter

# HELP scrape_errors_total Total number of scrape errors per job, target, collector and query
# TYPE scrape_errors_total counter
scrape_errors_total{collector="crunchy_pgbackrest",job="global_targets",query="ccp_backrest_last_info",target="global"} 245
Jul 25 14:00:39 cd-dc1-pg2 sql_exporter[10651]: ts=2024-07-25T18:00:39.177Z caller=klog.go:134 level=error func=Errorf msg="Error gathering metrics: [from Gatherer #1] [job=global_targets,target=global,collector=crunchy_pgbackrest,query=ccp_backrest_last_info] sql: Scan error on column index 0, name \"backrest_repo_version\": converting driver.Value type string (\"2.52.1\") to a float64: invalid syntax"

postgres_exporter

Jul 25 14:41:19 cd-dc1-pg1 postgres_exporter[11231]: ts=2024-07-25T18:41:19.594Z caller=util.go:92 level=info msg="Could not parse string" err="strconv.ParseFloat: parsing \"2.52.1\": invalid syntax"
Jul 25 14:41:19 cd-dc1-pg1 postgres_exporter[11231]: ts=2024-07-25T18:41:19.594Z caller=namespace.go:241 level=info err="Unexpected error parsing column:  ccp_backrest_last_info backrest_repo_version 2.52.1\n"

Describe the expected behavior:

Should be able to handle any version of pgBackRest.

If users currently are not on version 2.52, we recommend waiting to upgrade. If you have upgraded to 2.52.1, please upgrade to 2.53 when it is available. This will be fixed in the next release of pgMonitor for postgres_exporter. For sql_exporter, this will be fixed in the pgmonitor-extension version 1.0.1, so no update to pgMonitor will be required.

Tell us about your environment:

  • pgMonitor version: 5.0 and older
  • Container or non-container:
  • Container name / image:
  • Operating System for non-container:
  • PostgreSQL Version: N/A
  • Exporter(s) in use (incl. version): postgres, sql
  • Prometheus version: Any
  • AlertManager version: Any
  • Grafana version: Any
@keithf4 keithf4 added UNCONFIRMED Initial state. Need's triaged BUG Something isn't working and removed UNCONFIRMED Initial state. Need's triaged labels Jul 25, 2024
@keithf4 keithf4 self-assigned this Jul 25, 2024
@keithf4 keithf4 added this to the 5.1 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant