-
Notifications
You must be signed in to change notification settings - Fork 1
RB-1500 - Prevent too large image uploads on designation pages #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I see you added the "On Staging" label, I'll get this merged to the staging branch! |
|
Code looks good, but staging isn't updating because CI is failing: https://github.com/CruGlobal/give-web/actions/runs/19965823839/job/57257611535?pr=1259 It looks like Line 12 in a3b1585
|
|
I see a different one here: https://www.npmjs.com/package/angular-environment |
|
It looks like the main reason for switching was to remove a console.log statement; maybe worth going back |
fa41ece to
fd853a6
Compare
canac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're on code freeze, so this can't be merged for another month or so, but it looks great! Thanks for the improvement!
|
I might ask Mike Nelson about that; quite a few people are trying to update their giving pages to handle end of year giving and are running into this error with zero feedback from our system on why they can't upload an image. This is completely separate from the checkout process so he might be willing to let it go through. |
Oh OK! If Mike is good with it then I am. Have you talked with him about this issue? If you haven't yet I can reach out unless you'd like to. |
|
I reached out to him today, he is fine with it going live during code freeze since it has no impact on checkout and the risk is low. |
The only risk in my mind is switching out the A Monday deployment might be wise, but feel free to deploy whenever. |
|
I'm going to go ahead and merge. I keep getting these errors coming through, and there is plenty of time to rollback today if needed. |
Description
Rollbar
The AEM reverse replication process cannot handle files that are too large. It converts the image bytes into JSON, which adds some bloat to the file, which is why I'm using 15MB here instead of 20MB.
Testing
Do the same steps above with the carousel editor.
Checklist:
stage-branch-mergersuccessfully merged my branch to staging or manually merged it myself