Address several UX issues #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 15, 2023 14:48
update the JS code to sync with changes in the response returned by `.../module-versions`
corrected attribute generation code in `debugLog()` to work correctly when >1 k/v pair is provided
update gRPC client dial options to use TLS by default added new `--insecure` CLI flag to explicitly disable TLS
…o stable versions updated `query list-modules` to try to find a pre-release version if no stable version exists for a module
jeffmclean-cs
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues found while using Perseus internally at CrowdStrike.
--insecureflag to thequeryandupdatecommands to manually disable TLS where necessary (such as when doing local debugging).../module-versionsendpoint and the UI was not updatedquery list-moduleswould fail if a module has no stable versions in the database