Fix NGSIEM stop_search parameter handling (Issue #1398)#1421
Open
jayy-77 wants to merge 3 commits intoCrowdStrike:devfrom
Open
Fix NGSIEM stop_search parameter handling (Issue #1398)#1421jayy-77 wants to merge 3 commits intoCrowdStrike:devfrom
jayy-77 wants to merge 3 commits intoCrowdStrike:devfrom
Conversation
This commit fixes two related bugs in the stop_search method: 1. Parameter Mismatch: The documentation specified 'id' parameter but the method only accepted 'search_id', causing user confusion. 2. Missing Alias Support: Unlike get_search_status which accepts both 'id' and 'search_id' keywords, stop_search only accepted 'search_id'. Changes: - Updated stop_search() to accept both 'id' and 'search_id' parameters - Improved documentation to clarify both parameters are supported - Fixed error message to reference 'id' instead of 'search_id' - Added comprehensive tests for both parameter variants - Enhanced existing integration tests to cover both approaches This brings stop_search behavior in line with get_search_status and resolves the 'No content was received for this request' error that users encountered when using the 'id' parameter as documented. Fixes CrowdStrike#1398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes two related bugs in the stop_search method:
Parameter Mismatch: The documentation specified 'id' parameter but the method only accepted 'search_id', causing user confusion.
Missing Alias Support: Unlike get_search_status which accepts both 'id' and 'search_id' keywords, stop_search only accepted 'search_id'.
Changes:
This brings stop_search behavior in line with get_search_status and resolves the 'No content was received for this request' error that users encountered when using the 'id' parameter as documented.
Fixes #1398