Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to 1.21.0 #257

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Update SDK to 1.21.0 #257

merged 1 commit into from
Jun 16, 2022

Conversation

jsullivan-CS
Copy link
Contributor

Expected changes to update SDK to 1.21.0; would like to verify with a current maintainer.

Copy link
Contributor

@redhatrises redhatrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of additional things:

  1. Can you remove the falcon-operator binary file
  2. Also, looks like the metadata is missing the relatedImages content. e.g.
    +  relatedImages:
    +  - image: "" 
    +    name: node-sensor
    

.tool-versions Outdated Show resolved Hide resolved
@redhatrises
Copy link
Contributor

@jsullivan-CS
Copy link
Contributor Author

Also, reading the 1.21 release notes, it seems like the following changes were missed:

  1. https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.21.0/#for-golanghelmansible-based-operators-upgrade-kube-rbac-proxy-image-from-v080-to-v0110-for-further-information-see-the-kube-rbac-proxy-release-noteshttpsgithubcombranczkube-rbac-proxyreleases
  2. https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.21.0/#for-golang-based-operators--change-makefile-targets-to-replace-go-get-with-go-install

If you can, add them to this PR, please. Or if you want, I can create a follow up PR to this one with the necessary changes.

Thanks for opening this PR!

🙇 Thanks very much for the feedback; changes included in the most recent commit update.

@isimluk isimluk merged commit 9965723 into CrowdStrike:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants