Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a little more clarity on status error messages #255

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Provide a little more clarity on status error messages #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions controllers/falcon/falconnodesensor_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ func (r *FalconNodeSensorReconciler) Reconcile(ctx context.Context, req ctrl.Req
nodesensor.Status.Sensor = &strings.Split(image, ":")[1]
err = r.Status().Update(ctx, nodesensor)
if err != nil {
log.Error(err, "Failed to update FalconNodeSensor status")
log.Error(err, "Failed to update FalconNodeSensor status for nodesensor.Status.Sensor")
return ctrl.Result{}, err
}
}
Expand All @@ -270,7 +270,7 @@ func (r *FalconNodeSensorReconciler) Reconcile(ctx context.Context, req ctrl.Req
nodesensor.Status.Version = version.Get()
err = r.Status().Update(ctx, nodesensor)
if err != nil {
log.Error(err, "Failed to update FalconNodeSensor status")
log.Error(err, "Failed to update FalconNodeSensor status for nodesensor.Status.Version")
return ctrl.Result{}, err
}
}
Expand Down Expand Up @@ -683,7 +683,7 @@ func (r *FalconNodeSensorReconciler) conditionsUpdate(condType string, status me
})

if err := r.Status().Update(ctx, nodesensor); err != nil {
logger.Error(err, "Failed to update FalconNodeSensor status")
logger.Error(err, "Failed to update FalconNodeSensor status", "Failed to update the Condition at Reasoning", reason)
return err
}

Expand Down