Remove controller-manager uid and gid settings #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
suggested changes
Feb 25, 2022
|
I was getting errors deploying the controller due to uid being to small for the uid range... Ironically, now I am not. Closing this for now. |
|
I have now run into the same issue as well. Ironically, I don't think I did anything to trigger it. If we merge this, we kinda drop support for OpenShift 4.7 as this piece of config was introduced to support similar yet different error on OpenShift 4.7. Alternatively, we could drop |
|
FYI, OpenShift 4.7 is getting close to its EOL: https://access.redhat.com/support/policy/updates/openshift |
redhatrises
force-pushed
the
fix_manager_perms
branch
from
fdf17fd
to
e10e637
Compare
- Current uid/gid settings for the controller manager break on more security conscious kubernetes distros where uid/gid is generated off of a random uid range that might require uid/gid to be > 65000
redhatrises
force-pushed
the
fix_manager_perms
branch
from
e10e637
to
6758072
Compare
isimluk
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes distros where uid/gid is generated off of a random uid range that might
require uid/gid to be > 65000