Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate OpenShift infra nodes #459

Closed
evanstoner opened this issue Nov 15, 2023 · 2 comments · Fixed by #463
Closed

Tolerate OpenShift infra nodes #459

evanstoner opened this issue Nov 15, 2023 · 2 comments · Fixed by #463
Assignees

Comments

@evanstoner
Copy link
Contributor

Infra nodes can be used in self-managed or SRE-managed OpenShift clusters. They are worker nodes with a node-role.kubernetes.io/infra label and a node-role.kubernetes.io/infra NoSchedule taint. We should tolerate this taint, like we already tolerate master and control-plane, to provide full cluster protection out of the box.

Example in ROSA: https://console-openshift-console.apps.estoner412.r4al.p1.openshiftapps.com/k8s/ns/openshift-machine-api/machine.openshift.io~v1beta1~MachineSet/estoner412-hlwr4-infra-us-west-1a/yaml

Docs: https://docs.openshift.com/container-platform/4.14/machine_management/creating-infrastructure-machinesets.html

@redhatrises
Copy link
Contributor

@evanstoner are you wanting the infra label to be a toleration by default so that it will automatically be added?

@evanstoner
Copy link
Contributor Author

Yes, tolerate infra label by default. This way we will deploy to all standard tainted node types by default.

redhatrises added a commit to redhatrises/falcon-operator that referenced this issue Dec 8, 2023
redhatrises added a commit to redhatrises/falcon-operator that referenced this issue Dec 8, 2023
redhatrises added a commit that referenced this issue Dec 22, 2023
redhatrises added a commit that referenced this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants