Merge pull request #581 from CrowdStrike/mhyson/advanced

feat: advanced settings

api/falcon/v1alpha1/unsafe.go → api/falcon/v1alpha1/advanced.go

@@ -8,10 +8,10 @@ const (
 	Off    = "off"
 )
 
-// FalconUnsafe configures various options that go against industry practices or are otherwise not recommended for use.
+// FalconAdvanced configures various options that go against industry practices or are otherwise not recommended for use.
 // Adjusting these settings may result in incorrect or undesirable behavior. Proceed at your own risk.
-// For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/UNSAFE.md.
-type FalconUnsafe struct {
+// For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/docs/ADVANCED.md.
+type FalconAdvanced struct {
 	// UpdatePolicy is the name of a sensor update policy configured and enabled in Falcon UI. It is ignored when Image and/or Version are set.
 	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Falcon Sensor Update Policy",order=1
 	UpdatePolicy *string `json:"updatePolicy,omitempty"`
@@ -24,30 +24,30 @@ type FalconUnsafe struct {
 	AutoUpdate *string `json:"autoUpdate,omitempty"`
 }
 
-func (notSafe FalconUnsafe) GetUpdatePolicy() string {
-	if notSafe.UpdatePolicy == nil {
+func (advanced FalconAdvanced) GetUpdatePolicy() string {
+	if advanced.UpdatePolicy == nil {
 		return ""
 	}
 
-	return strings.TrimSpace(*notSafe.UpdatePolicy)
+	return strings.TrimSpace(*advanced.UpdatePolicy)
 }
 
-func (notSafe FalconUnsafe) HasUpdatePolicy() bool {
-	return notSafe.GetUpdatePolicy() != ""
+func (advanced FalconAdvanced) HasUpdatePolicy() bool {
+	return advanced.GetUpdatePolicy() != ""
 }
 
-func (notSafe FalconUnsafe) IsAutoUpdating() bool {
-	if notSafe.AutoUpdate == nil {
+func (advanced FalconAdvanced) IsAutoUpdating() bool {
+	if advanced.AutoUpdate == nil {
 		return false
 	}
 
-	return *notSafe.AutoUpdate != "off"
+	return *advanced.AutoUpdate != "off"
 }
 
-func (notSafe FalconUnsafe) IsAutoUpdatingForced() bool {
-	if notSafe.AutoUpdate == nil {
+func (advanced FalconAdvanced) IsAutoUpdatingForced() bool {
+	if advanced.AutoUpdate == nil {
 		return false
 	}
 
-	return *notSafe.AutoUpdate == "force"
+	return *advanced.AutoUpdate == "force"
 }

api/falcon/v1alpha1/falconcontainer_types.go

@@ -44,11 +44,11 @@ type FalconContainerSpec struct {
 	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Falcon Container Image Version",order=6
 	Version *string `json:"version,omitempty"`
 
-	// FalconUnsafe configures various options that go against industry practices or are otherwise not recommended for use.
+	// Advanced configures various options that go against industry practices or are otherwise not recommended for use.
 	// Adjusting these settings may result in incorrect or undesirable behavior. Proceed at your own risk.
-	// For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/UNSAFE.md.
-	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Falcon Container Unsafe Settings"
-	Unsafe FalconUnsafe `json:"unsafe,omitempty"`
+	// For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/docs/ADVANCED.md.
+	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Falcon Container Advanced Settings"
+	Advanced FalconAdvanced `json:"advanced,omitempty"`
 }
 
 type FalconContainerInjectorSpec struct {

api/falcon/v1alpha1/falconnodesensor_types.go

@@ -104,11 +104,11 @@ type FalconNodeSensorConfig struct {
 	// Version of the sensor to be installed. The latest version will be selected when this version specifier is missing.
 	Version *string `json:"version,omitempty"`
 
-	// FalconUnsafe configures various options that go against industry practices or are otherwise not recommended for use.
+	// Advanced configures various options that go against industry practices or are otherwise not recommended for use.
 	// Adjusting these settings may result in incorrect or undesirable behavior. Proceed at your own risk.
-	// For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/UNSAFE.md.
-	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="DaemonSet Unsafe Settings"
-	Unsafe FalconUnsafe `json:"unsafe,omitempty"`
+	// For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/docs/ADVANCED.md.
+	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="DaemonSet Advanced Settings"
+	Advanced FalconAdvanced `json:"advanced,omitempty"`
 }
 
 type PriorityClassConfig struct {

api/falcon/v1alpha1/zz_generated.deepcopy.go

@@ -537,6 +537,31 @@ func (in *FalconAdmissionUpdateStrategy) DeepCopy() *FalconAdmissionUpdateStrate
 	return out
 }
 
+// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
+func (in *FalconAdvanced) DeepCopyInto(out *FalconAdvanced) {
+	*out = *in
+	if in.UpdatePolicy != nil {
+		in, out := &in.UpdatePolicy, &out.UpdatePolicy
+		*out = new(string)
+		**out = **in
+	}
+	if in.AutoUpdate != nil {
+		in, out := &in.AutoUpdate, &out.AutoUpdate
+		*out = new(string)
+		**out = **in
+	}
+}
+
+// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new FalconAdvanced.
+func (in *FalconAdvanced) DeepCopy() *FalconAdvanced {
+	if in == nil {
+		return nil
+	}
+	out := new(FalconAdvanced)
+	in.DeepCopyInto(out)
+	return out
+}
+
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *FalconCRStatus) DeepCopyInto(out *FalconCRStatus) {
 	*out = *in
@@ -739,7 +764,7 @@ func (in *FalconContainerSpec) DeepCopyInto(out *FalconContainerSpec) {
 		*out = new(string)
 		**out = **in
 	}
-	in.Unsafe.DeepCopyInto(&out.Unsafe)
+	in.Advanced.DeepCopyInto(&out.Advanced)
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new FalconContainerSpec.
@@ -1033,7 +1058,7 @@ func (in *FalconNodeSensorConfig) DeepCopyInto(out *FalconNodeSensorConfig) {
 		*out = new(string)
 		**out = **in
 	}
-	in.Unsafe.DeepCopyInto(&out.Unsafe)
+	in.Advanced.DeepCopyInto(&out.Advanced)
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new FalconNodeSensorConfig.
@@ -1200,31 +1225,6 @@ func (in *FalconSensor) DeepCopy() *FalconSensor {
 	return out
 }
 
-// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
-func (in *FalconUnsafe) DeepCopyInto(out *FalconUnsafe) {
-	*out = *in
-	if in.UpdatePolicy != nil {
-		in, out := &in.UpdatePolicy, &out.UpdatePolicy
-		*out = new(string)
-		**out = **in
-	}
-	if in.AutoUpdate != nil {
-		in, out := &in.AutoUpdate, &out.AutoUpdate
-		*out = new(string)
-		**out = **in
-	}
-}
-
-// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new FalconUnsafe.
-func (in *FalconUnsafe) DeepCopy() *FalconUnsafe {
-	if in == nil {
-		return nil
-	}
-	out := new(FalconUnsafe)
-	in.DeepCopyInto(out)
-	return out
-}
-
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *PriorityClassConfig) DeepCopyInto(out *PriorityClassConfig) {
 	*out = *in

config/crd/bases/falcon.crowdstrike.com_falconcontainers.yaml

@@ -43,6 +43,30 @@ spec:
           spec:
             description: FalconContainerSpec defines the desired state of FalconContainer
             properties:
+              advanced:
+                description: Advanced configures various options that go against industry
+                  practices or are otherwise not recommended for use. Adjusting these
+                  settings may result in incorrect or undesirable behavior. Proceed
+                  at your own risk. For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/docs/ADVANCED.md.
+                properties:
+                  autoUpdate:
+                    description: AutoUpdate determines whether to install new versions
+                      of the sensor as they become available. Defaults to "off" and
+                      is ignored if FalconAPI is not set. Setting this to "force"
+                      causes the reconciler to run on every polling cycle, even if
+                      a new sensor version is not available. Setting it to "normal"
+                      only reconciles when a new version is detected.
+                    enum:
+                    - "off"
+                    - normal
+                    - force
+                    type: string
+                  updatePolicy:
+                    description: UpdatePolicy is the name of a sensor update policy
+                      configured and enabled in Falcon UI. It is ignored when Image
+                      and/or Version are set.
+                    type: string
+                type: object
               falcon:
                 description: CrowdStrike Falcon Sensor configuration settings.
                 properties:
@@ -1924,30 +1948,6 @@ spec:
                 required:
                 - type
                 type: object
-              unsafe:
-                description: FalconUnsafe configures various options that go against
-                  industry practices or are otherwise not recommended for use. Adjusting
-                  these settings may result in incorrect or undesirable behavior.
-                  Proceed at your own risk. For more information, please see https://github.com/CrowdStrike/falcon-operator/blob/main/UNSAFE.md.
-                properties:
-                  autoUpdate:
-                    description: AutoUpdate determines whether to install new versions
-                      of the sensor as they become available. Defaults to "off" and
-                      is ignored if FalconAPI is not set. Setting this to "force"
-                      causes the reconciler to run on every polling cycle, even if
-                      a new sensor version is not available. Setting it to "normal"
-                      only reconciles when a new version is detected.
-                    enum:
-                    - "off"
-                    - normal
-                    - force
-                    type: string
-                  updatePolicy:
-                    description: UpdatePolicy is the name of a sensor update policy
-                      configured and enabled in Falcon UI. It is ignored when Image
-                      and/or Version are set.
-                    type: string
-                type: object
               version:
                 description: Falcon Container Version. The latest version will be
                   selected when version specifier is missing; ignored when Image is

config/crd/bases/falcon.crowdstrike.com_falconnodesensors.yaml

@@ -138,6 +138,31 @@ spec:
               node:
                 description: Various configuration for DaemonSet Deployment
                 properties:
+                  advanced:
+                    description: Advanced configures various options that go against
+                      industry practices or are otherwise not recommended for use.
+                      Adjusting these settings may result in incorrect or undesirable
+                      behavior. Proceed at your own risk. For more information, please
+                      see https://github.com/CrowdStrike/falcon-operator/blob/main/docs/ADVANCED.md.
+                    properties:
+                      autoUpdate:
+                        description: AutoUpdate determines whether to install new
+                          versions of the sensor as they become available. Defaults
+                          to "off" and is ignored if FalconAPI is not set. Setting
+                          this to "force" causes the reconciler to run on every polling
+                          cycle, even if a new sensor version is not available. Setting
+                          it to "normal" only reconciles when a new version is detected.
+                        enum:
+                        - "off"
+                        - normal
+                        - force
+                        type: string
+                      updatePolicy:
+                        description: UpdatePolicy is the name of a sensor update policy
+                          configured and enabled in Falcon UI. It is ignored when
+                          Image and/or Version are set.
+                        type: string
+                    type: object
                   backend:
                     default: bpf
                     description: Sets the backend to be used by the DaemonSet Sensor.
@@ -516,31 +541,6 @@ spec:
                           type: string
                       type: object
                     type: array
-                  unsafe:
-                    description: FalconUnsafe configures various options that go against
-                      industry practices or are otherwise not recommended for use.
-                      Adjusting these settings may result in incorrect or undesirable
-                      behavior. Proceed at your own risk. For more information, please
-                      see https://github.com/CrowdStrike/falcon-operator/blob/main/UNSAFE.md.
-                    properties:
-                      autoUpdate:
-                        description: AutoUpdate determines whether to install new
-                          versions of the sensor as they become available. Defaults
-                          to "off" and is ignored if FalconAPI is not set. Setting
-                          this to "force" causes the reconciler to run on every polling
-                          cycle, even if a new sensor version is not available. Setting
-                          it to "normal" only reconciles when a new version is detected.
-                        enum:
-                        - "off"
-                        - normal
-                        - force
-                        type: string
-                      updatePolicy:
-                        description: UpdatePolicy is the name of a sensor update policy
-                          configured and enabled in Falcon UI. It is ignored when
-                          Image and/or Version are set.
-                        type: string
-                    type: object
                   updateStrategy:
                     description: Type of DaemonSet update. Can be "RollingUpdate"
                       or "OnDelete". Default is RollingUpdate.