Introduce aws_sqs backend #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow this looks good to me! So the process of selecting messages would be nice to parameterize. Or perhaps we have a way of inheriting a base aws SQS class, so that when I want to use SQS with cloudtrail-backend, I can simply pass RELEVANT_EVENT_TYPES. |
|
That is a next step. |
isimluk
force-pushed
the
add-aws-sqs
branch
2 times, most recently
from
0d93e6c
to
15c2977
Compare
carlosmmatos
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carlos, this is the initial version of the plain SQS backend. It just forwards selected messages from the CrowdStrike Falcon Event Stream to AWS SQS.
Interestingly, it works like a charm.