fix(falcon_configure): this task should only run when both are set #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue when the cid options was set to "" for it be deleted, and then it would get to this point and fail because the when clause was incorrect. A simple truthy test should provide us what we are looking for. Also added options.cid to this since it makes sense we would want to ensure both are set to use this task.
redhatrises
approved these changes
Sep 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564
There was an issue when the cid options was set to "" for it be deleted, and then it would get to this point and fail because the when clause was incorrect. A simple truthy test should provide us what we are looking for since we allow empty strings to be passed in to options for deletion purposes.
Also added options.cid to this since it makes sense we would want to ensure both are set to use this task.