falcon_install - add the ability to install from an url link for windows #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmmatos
added
enhancement
carlosmmatos
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
@HarishHary Looks good and thank you again for the contribution!
I updated the changelog to be minor_change instead of bugfix, and you only need to provide the fragment. When I create a new release, it will take your fragment and add it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello,
Sorry for the spam here... Reopened a new one due to a mistake that I did.
This PR is a clone of this one: #362