Skip to content

Conversation

@CeeEffEff
Copy link
Contributor

…derBy fields

What:
Reverses the order in which order bys are processed used in MockFirestore,

Why:
When adding pagination using multiple fields as part of https://croudtech.atlassian.net/browse/PT-606 discovered that mock-firestore implementation of orderBy is incorrect, as the last orderBy was overriding with primary (most significant) orderBy which is not how Firestore works.

Copy link
Contributor

@marian-stykhun marian-stykhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@BrockReece BrockReece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@CeeEffEff CeeEffEff merged commit baf1319 into main May 30, 2025
10 checks passed
@CeeEffEff CeeEffEff deleted the fix/multiple-orderby-fix branch May 30, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants