Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove close/reopen logic for file handle and fix Ecc crash on empty #16

Merged
merged 4 commits into from
Mar 12, 2016

Conversation

Ragora
Copy link
Contributor

@Ragora Ragora commented Mar 12, 2016

Remove the funny close/reopen logic I introduced in the last PR #12 I had merged in and fix crashes on 0 length files. Everything works on my Linux Mint AMD64 box here, though I don't know about Windows as per the last PR.

@Ragora
Copy link
Contributor Author

Ragora commented Mar 12, 2016

Sorry about all the tacked on commits, seems I'm not quite on top of my game today. Want me to rebase them down or is it good?

SLAwww pushed a commit that referenced this pull request Mar 12, 2016
Remove close/reopen logic for file handle and fix Ecc crash on empty
@SLAwww SLAwww merged commit 0a3be0b into Croteam-official:master Mar 12, 2016
@Ragora Ragora deleted the EccFixBase branch March 13, 2016 05:29
@xdevelnet
Copy link

Everything works on my Linux Mint AMD64 box here

hi @Ragora
can you provide build instructions under linux, please?

Thank you :)

@Ragora
Copy link
Contributor Author

Ragora commented Mar 13, 2016

@xdevelnet Currently only Ecc is building under Linux for me through my repository here: https://github.com/Ragora/Serious-Engine/tree/LinuxPort

There is word of Ryan C Gordon having working ports and is talking to Croteam about releasing it: https://twitter.com/icculus/status/708326894597488642

Otherwise, my repository currently has a bunch of build errors for anything aside from Ecc. But you can attempt a build using cmake in the sources folder over there: cmake . && make

A full port is probably going to take more work than I'm currently able to put in on it, so I'm mostly hoping Ryan can release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants