feat: add loggingConsent property to CrossmintConfig #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional loggingConsent boolean to CrossmintConfig type - Update logger initialization to only add Datadog sinks when loggingConsent is true - Update React base, React Native, and wallets SDK logger init functions - Pass loggingConsent through providers to logger initialization Co-Authored-By: Guille <guille.a@paella.dev>
|
Contributor
Original prompt from Guille |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Pass loggingConsent to initReactLogger and BaseCrossmintProvider - Ensure loggingConsent is properly propagated through the provider chain Co-Authored-By: Guille <guille.a@paella.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
loggingConsentboolean property toCrossmintConfigthat controls whether Datadog logging sinks are initialized. WhenloggingConsentis not set or isfalse, the SDK will not initialize Datadog logging. Only whenloggingConsent === truewill the Datadog sinks be added to the logger.This change affects:
@crossmint/client-sdk-react-base)@crossmint/client-sdk-react-native-ui)@crossmint/wallets-sdk)Important behavioral change: Previously, Datadog logging was always initialized. Now it requires explicit opt-in via
loggingConsent: true.Human review checklist:
Test plan
loggingConsentflagPackage updates
The following packages are affected:
@crossmint/common-sdk-base@crossmint/client-sdk-react-base@crossmint/client-sdk-react-native-ui@crossmint/wallets-sdkChangesets need to be added via
pnpm change:add.Link to Devin run: https://app.devin.ai/sessions/9db5b04fc72b4917a805252a8e42bb79
Requested by: Guille (guille.a@paella.dev) (@guilleasz-crossmint)