Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed oversized rank model on match summary screen #291

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Kruphixx
Copy link
Contributor

Seems to have been caused by 8c32405?

Before:
prefix

After:
fix

@qkeitoe
Copy link

qkeitoe commented Sep 16, 2024

I think it is better to put those former values inside the if_mini statement (or rather only the value for fov, since the values for ypos and tall are already overwritten there), so that they are only applied to the match summary screen. This would keep the fix for the main menu from 8c32405.

@Kruphixx
Copy link
Contributor Author

I think it is better to put those former values inside the if_mini statement (or rather only the value for fov, since the values for ypos and tall are already overwritten there), so that they are only applied to the match summary screen. This would keep the fix for the main menu from 8c32405.

Somehow didn't think of that, thanks.

@CriticalFlaw
Copy link
Owner

Does it still look fine in 4:3?

@Kruphixx
Copy link
Contributor Author

Looks fine in the main menu and good enough on the match end screen.

20240917141116_1

@CriticalFlaw
Copy link
Owner

Excellent. Thank you both for contributing.

@CriticalFlaw CriticalFlaw merged commit 8ad542d into CriticalFlaw:main Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants