Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Eslint v9 #924

Merged
merged 4 commits into from
Jun 6, 2024
Merged

feat: Eslint v9 #924

merged 4 commits into from
Jun 6, 2024

Conversation

deepanchal
Copy link
Contributor

@deepanchal deepanchal commented Jun 5, 2024

Description

  • feat(lint): migrate eslint to v9, update config, deps, lockfile
  • feat(lint): change eslint config, update lint cmd in package.json

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

@deepanchal
Copy link
Contributor Author

Waiting on this PR to be merged: import-js/eslint-plugin-import#2873

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.52%. Comparing base (0984125) to head (61c2024).

Files Patch % Lines
src/components/Editor.vue 0.00% 2 Missing ⚠️
src/main.ts 0.00% 2 Missing ⚠️
src/components/live/D3BarChart.vue 0.00% 1 Missing ⚠️
src/hooks/worksite/useRenderedMarkers.ts 0.00% 1 Missing ⚠️
src/utils/downloads.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   15.52%   15.52%           
=======================================
  Files         380      380           
  Lines       80964    80970    +6     
  Branches      848      848           
=======================================
+ Hits        12567    12568    +1     
- Misses      68397    68402    +5     
Flag Coverage Δ
unitTests 15.52% <12.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepanchal deepanchal marked this pull request as draft June 5, 2024 20:24
Copy link

github-actions bot commented Jun 5, 2024

Playwright test results

passed  48 passed
flaky  4 flaky

Details

stats  52 tests across 12 suites
duration  5 minutes, 5 seconds
commit  61c2024

Flaky tests

chromium-setup › auth.setup.ts › authenticate as user - ( @primary @slow @read @development @staging @production )
firefox-setup › auth.setup.ts › authenticate as user - ( @primary @slow @read @development @staging @production )
chromium › pages/login.test.ts › LoginPage › should show error on login with invalid credentials - ( @slow @primary @development @staging @production )
firefox › pages/work.test.ts › WorkPage › should have visible data-testids - ( @primary @slow @read @development @staging @production )

Signed-off-by: Deep Panchal <deep302001@gmail.com>
Signed-off-by: Deep Panchal <deep302001@gmail.com>
Signed-off-by: Deep Panchal <deep302001@gmail.com>
…adds eslint flat config support

- import-js/eslint-plugin-import#2873

Signed-off-by: Deep Panchal <deep302001@gmail.com>
@deepanchal deepanchal marked this pull request as ready for review June 6, 2024 15:38
@deepanchal deepanchal merged commit c50f61f into master Jun 6, 2024
17 of 18 checks passed
@deepanchal deepanchal deleted the feat/eslint-v9 branch June 6, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant