Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.8 compatibility #550

Closed
wants to merge 1 commit into from
Closed

Laravel 5.8 compatibility #550

wants to merge 1 commit into from

Conversation

lloricode
Copy link

Laravel 5.8 compatibility, and update unit test with deprecated assertion (wip).

also wait to merge this to fix the failed assert.

…tion (wip).

also wait to merge this to fix the failed assert.

Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
@MoogyG
Copy link

MoogyG commented Mar 31, 2019

I don't understand why it takes so long to merge this.
I really respect your work @Crinsane but if you don't want to manage this package anymore, please edit your README and add "deprecated".

@agjmills
Copy link

👍

@devarda
Copy link

devarda commented Jul 17, 2019

+1

camilopayan added a commit to MPEnterprises/LaravelShoppingcart that referenced this pull request Aug 16, 2019
camilopayan added a commit to MPEnterprises/LaravelShoppingcart that referenced this pull request Aug 16, 2019
camilopayan added a commit to MPEnterprises/LaravelShoppingcart that referenced this pull request Aug 16, 2019
camilopayan added a commit to MPEnterprises/LaravelShoppingcart that referenced this pull request Aug 16, 2019
@lloricode
Copy link
Author

this is so loooooooooooooooooooooooooooooooooooong

@lloricode
Copy link
Author

guys you can use this https://github.com/darryldecode/laravelshoppingcart,

@lloricode
Copy link
Author

Resolve #548

@lloricode lloricode closed this Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants