Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Commit

Permalink
[Added] Layout challenge modifications (#3)
Browse files Browse the repository at this point in the history
* add layout challenge

* [Removed] Layout br version

Co-authored-by: nico-creditas <57908373+nico-creditas@users.noreply.github.com>
  • Loading branch information
emartz404 and nico-creditas authored Feb 10, 2020
1 parent cd56525 commit 0331060
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 7 deletions.
13 changes: 11 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ You have to improve the loan simulator implemented in this project.

Both the interface as well as the styles are provided. The challenges include refactoring the code and implementing new functionalities (listed below).

Feel free to componentize whatever you think should be componentized. Our only request is that you use only pure JavaScript, our beloved Vanilla. Do you accept the challenge?
Feel free to componetize whatever you think should be componetized. Our only request is that you use only pure JavaScript, our beloved Vanilla. Do you accept the challenge?

This is the simulator current state:

Expand Down Expand Up @@ -78,6 +78,15 @@ Please find the corresponding values below:

Finally, you must update the monthly payment value whenever any input changes.

### Layout
The template requires some minor css changes in order to be displayed as proposed in the references provided. Feel free to use any property you feel like to achieve so.

Desktop version:
![Desktop version](./desktop-layout.png)

Mobile version:
![Mobile version](./mobile-layout.png)

## Development

### Prerequisites
Expand Down Expand Up @@ -126,4 +135,4 @@ npm test
- In the meantime, please give us your sincere (no sugar coating!) [https://docs.google.com/forms/d/e/1FAIpQLSdwjudz38JMtMYf3rFBrMHX3XMy2J5oBLPnjBGD1QKvOM2SGg/viewform](opinion) on the challenge.
We would like you to send it **even if you didn't finish the challenge**. Here at Creditas, constructive feedbacks are part of our culture.

Thanks for your time and interest in joining us!!
Thanks for your time and interest in joining us!!
Binary file added desktop-layout.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed layout_br.png
Binary file not shown.
Binary file added mobile-layout.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 2 additions & 5 deletions src/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,7 @@ body {
}

.field {
display: flex;
flex-direction: column;
justify-content: center;
display: inherit;
}

.field-group .field:first-child {
Expand Down Expand Up @@ -125,8 +123,7 @@ body {
}

.range__values {
display: flex;
justify-content: space-between;
display: inherit;
}

.range__values span {
Expand Down

0 comments on commit 0331060

Please sign in to comment.