Fix crash with null level during world gen (from third party mods) #8323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoidLeech
added
pr type: fix
|
Fixes #8268 |
|
noticed this thread was mentioned on my report, is your temp fix public? something o i can generate that chunk and finish the pregen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm using Create with a bunch of other mods and datapacks, and one of them generates Belt Tunnel blocks in structures, sometimes causing crashes during world gen.
The crashes happened during the feature placement phase, so probably because of that the "level" variable in the Block Entity was null (or maybe Chunky was the culprit, I don't know), causing a crash when accessing a blockState in updateTunnelConnections.
I don't have the stack of the crash to show you, but after adding this null check the crash went away and the worldgen could contiune its job. Probably the generated blocks are forming a broken/non-functional machine, but it probably doesn't matter in this case (this is my first time using Create, so I don't know what those "flaps" are haha).