Filters on Contraption Controls are not rendered properly

[fabien-gigante]

Description

Filters on Contraption Controls are rendered flat. This flattening seems to somehow mess up the backface culling. Resulting in filter not being displayed properly.

Game Log

https://mclo.gs/r0YZlv8

Debug Information

Client Info

Create:
	Mod Version: 6.0.6
	Mod Git Commit: unknown
	Ponder Version: 1.0.56
	NeoForge Version: 21.1.176
	Minecraft Version: 1.21.1

Graphics:
	Flywheel Version: 1.0.4
	Flywheel Backend: colorwheel:instancing
	OpenGL Renderer: NVIDIA GeForce GTX 1650/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 560.94
	Graphics Mode: fancy
	PojavLauncher Detected: false

System Information:
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 22.0.2, Oracle Corporation
	JVM Flags: 35 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx12G -Xms12G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:NmethodSweepActivity=1 -XX:MaxNodeLimit=240000 -XX:NodeLimitFudgeFactor=8000 -XX:+PerfDisableSharedMem -XX:+UseFastUnorderedTimeStamps -XX:+UseCriticalJavaThreadPriority -XX:AllocatePrefetchStyle=3 -XX:+DisableExplicitGC -XX:G1NewSizePercent=28 -XX:G1HeapRegionSize=16M -XX:G1ReservePercent=20 -XX:G1MixedGCCountTarget=3 -XX:InitiatingHeapOccupancyPercent=10 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=0 -XX:SurvivorRatio=32 -XX:MaxTenuringThreshold=1 -XX:G1SATBBufferEnqueueingThresholdPercent=30 -XX:G1ConcRSHotCardLimit=16 -XX:G1ConcRefinementServiceIntervalMillis=150 -XX:-DontCompileHugeMethods
	Memory: 9711770200 bytes (9261 MiB) / 12884901888 bytes (12288 MiB) up to 12884901888 bytes (12288 MiB)
	Total Memory: 3184895648 bytes (3037 MiB) / 12884901888 bytes (12288 MiB)
	CPU: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz @ 3.54 GHz; 4 cores / 8 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
	Concurrent Chunk Management Engine (Fixes/WorldGen/Threading Issues): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Threading/Lighting): 0.3.0+alpha.0.71+1.21.1
	Forgified Fabric Renderer API (v1): 3.4.0+acb05a3919
	Colorwheel Patcher: 0.2.4+mc1.21.1
	Concurrent Chunk Management Engine (Rewrites/Chunk Serializer): 0.3.0+alpha.0.71+1.21.1
	Just Enough Items: 19.22.0.315
	Lithium: 0.15.0+mc1.21.1
	Flerovium: 1.0.4
	Concurrent Chunk Management Engine (Optimizations/Natives Math): 0.3.0+alpha.0.71+1.21.1
	TRender: 1.0.5
	Create: Winery: 1.7.0
	Create: Dragons Plus: 1.6.1
	ClickThrough Plus: 3.4+1.21.1
	Concurrent Chunk Management Engine (Fixes/General/Threading Issues): 0.3.0+alpha.0.71+1.21.1
	What Am I Listening To?: 21.0.2.0
	ModernFix: 5.24.3+mc1.21.1
	Alternate Current: 1.9.0
	Forgified Fabric BlockView API (v2): 1.0.10+9afaaf8c19
	Iris: 1.8.12-snapshot+mc1.21.1-local
	Create: Integrated Farming: 1.0.6
	Create Encased: 1.7.1-fix2
	Concurrent Chunk Management Engine (Optimizations/Math): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Rewrites/Chunk System): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine: 0.3.0+alpha.0.71+1.21.1
	Create New Beginnings: 0.1.0
	Sodium: 0.6.13+mc1.21.1
	Crate Delight: 24.11.22-1.21-neoforge
	VisibleToggleSprint: 1.7.0
	CreateBetterFps: 1.1.1
	Concurrent Chunk Management Engine (Base): 0.3.0+alpha.0.71+1.21.1
	Cloth Config v15 API: 15.0.140
	Concurrent Chunk Management Engine (Optimizations/Vanilla WorldGen): 0.3.0+alpha.0.71+1.21.1
	Fzzy Config: 0.6.9+1.21+neoforge
	Concurrent Chunk Management Engine (Fixes/WorldGen/Vanilla Bugs): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Optimizations/Scheduling): 0.3.0+alpha.0.71+1.21.1
	Advancements Reloaded: 0.6.1
	Corpse: 1.21.1-1.1.10
	Farmer's Delight: 1.2.8
	Forgified Fabric API Base: 0.4.42+d1308ded19
	Concurrent Chunk Management Engine (Fixes/Chunk IO/Threading Issues): 0.3.0+alpha.0.71+1.21.1
	Jade: 15.10.2+neoforge
	Concurrent Chunk Management Engine (Client/Uncap View Distance): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Server Utils): 0.3.0+alpha.0.71+1.21.1
	Kotlin For Forge: 5.8.0
	Concurrent Chunk Management Engine (Optimizations/Density Function Compiler): 0.3.0+alpha.0.71+1.21.1
	Armor Stand Poses: 1.3.0
	Create: Trading Floor: 3.0.10
	Concurrent Chunk Management Engine (No Tick View Distance): 0.3.0+alpha.0.71+1.21.1
	EntityCulling: 1.8.2
	Concurrent Chunk Management Engine (Optimizations/General WorldGen): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Optimizations/Chunk IO): 0.3.0+alpha.0.71+1.21.1
	More Culling: 1.0.6
	ImmediatelyFast: 1.6.6+1.21.1
	AppleSkin: 3.0.5+mc1.21
	Architectury: 13.0.8
	Ferrite Core: 7.0.2
	conditional mixin: 0.6.4
	TRansition: 1.0.3
	Forgified Fabric Rendering Data Attachment (v1): 0.3.48+73761d2e19
	BetterF3: 11.0.3
	Colorwheel: 0.2.3+mc1.21.1
	Jade Addons: 6.1.0+neoforge
	Concurrent Chunk Management Engine (Rewrites/Chunk IO): 0.3.0+alpha.0.71+1.21.1
	ShulkerBoxTooltip: 5.1.6+1.21.1
	Create: Enchantment Industry: 2.1.7
	Concurrent Chunk Management Engine (Optimizations/Memory Allocations): 0.3.0+alpha.0.71+1.21.1
	Create Slice & Dice: 0.0.0-dev
	Vanillin: 1.1.3

Server Info

Create:
	Mod Version: 6.0.6
	Mod Git Commit: unknown
	Ponder Version: 1.0.56
	NeoForge Version: 21.1.176
	Minecraft Version: 1.21.1

System Information:
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 22.0.2, Oracle Corporation
	JVM Flags: 35 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx12G -Xms12G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:NmethodSweepActivity=1 -XX:MaxNodeLimit=240000 -XX:NodeLimitFudgeFactor=8000 -XX:+PerfDisableSharedMem -XX:+UseFastUnorderedTimeStamps -XX:+UseCriticalJavaThreadPriority -XX:AllocatePrefetchStyle=3 -XX:+DisableExplicitGC -XX:G1NewSizePercent=28 -XX:G1HeapRegionSize=16M -XX:G1ReservePercent=20 -XX:G1MixedGCCountTarget=3 -XX:InitiatingHeapOccupancyPercent=10 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=0 -XX:SurvivorRatio=32 -XX:MaxTenuringThreshold=1 -XX:G1SATBBufferEnqueueingThresholdPercent=30 -XX:G1ConcRSHotCardLimit=16 -XX:G1ConcRefinementServiceIntervalMillis=150 -XX:-DontCompileHugeMethods
	Memory: 9711770200 bytes (9261 MiB) / 12884901888 bytes (12288 MiB) up to 12884901888 bytes (12288 MiB)
	Total Memory: 3184895648 bytes (3037 MiB) / 12884901888 bytes (12288 MiB)
	CPU: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz @ 3.54 GHz; 4 cores / 8 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
	Concurrent Chunk Management Engine (Fixes/WorldGen/Threading Issues): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Threading/Lighting): 0.3.0+alpha.0.71+1.21.1
	Forgified Fabric Renderer API (v1): 3.4.0+acb05a3919
	Colorwheel Patcher: 0.2.4+mc1.21.1
	Concurrent Chunk Management Engine (Rewrites/Chunk Serializer): 0.3.0+alpha.0.71+1.21.1
	Just Enough Items: 19.22.0.315
	Lithium: 0.15.0+mc1.21.1
	Flerovium: 1.0.4
	Concurrent Chunk Management Engine (Optimizations/Natives Math): 0.3.0+alpha.0.71+1.21.1
	TRender: 1.0.5
	Create: Winery: 1.7.0
	Create: Dragons Plus: 1.6.1
	ClickThrough Plus: 3.4+1.21.1
	Concurrent Chunk Management Engine (Fixes/General/Threading Issues): 0.3.0+alpha.0.71+1.21.1
	What Am I Listening To?: 21.0.2.0
	ModernFix: 5.24.3+mc1.21.1
	Alternate Current: 1.9.0
	Forgified Fabric BlockView API (v2): 1.0.10+9afaaf8c19
	Iris: 1.8.12-snapshot+mc1.21.1-local
	Create: Integrated Farming: 1.0.6
	Create Encased: 1.7.1-fix2
	Concurrent Chunk Management Engine (Optimizations/Math): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Rewrites/Chunk System): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine: 0.3.0+alpha.0.71+1.21.1
	Create New Beginnings: 0.1.0
	Sodium: 0.6.13+mc1.21.1
	Crate Delight: 24.11.22-1.21-neoforge
	VisibleToggleSprint: 1.7.0
	CreateBetterFps: 1.1.1
	Concurrent Chunk Management Engine (Base): 0.3.0+alpha.0.71+1.21.1
	Cloth Config v15 API: 15.0.140
	Concurrent Chunk Management Engine (Optimizations/Vanilla WorldGen): 0.3.0+alpha.0.71+1.21.1
	Fzzy Config: 0.6.9+1.21+neoforge
	Concurrent Chunk Management Engine (Fixes/WorldGen/Vanilla Bugs): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Optimizations/Scheduling): 0.3.0+alpha.0.71+1.21.1
	Advancements Reloaded: 0.6.1
	Corpse: 1.21.1-1.1.10
	Farmer's Delight: 1.2.8
	Forgified Fabric API Base: 0.4.42+d1308ded19
	Concurrent Chunk Management Engine (Fixes/Chunk IO/Threading Issues): 0.3.0+alpha.0.71+1.21.1
	Jade: 15.10.2+neoforge
	Concurrent Chunk Management Engine (Client/Uncap View Distance): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Server Utils): 0.3.0+alpha.0.71+1.21.1
	Kotlin For Forge: 5.8.0
	Concurrent Chunk Management Engine (Optimizations/Density Function Compiler): 0.3.0+alpha.0.71+1.21.1
	Armor Stand Poses: 1.3.0
	Create: Trading Floor: 3.0.10
	Concurrent Chunk Management Engine (No Tick View Distance): 0.3.0+alpha.0.71+1.21.1
	EntityCulling: 1.8.2
	Concurrent Chunk Management Engine (Optimizations/General WorldGen): 0.3.0+alpha.0.71+1.21.1
	Concurrent Chunk Management Engine (Optimizations/Chunk IO): 0.3.0+alpha.0.71+1.21.1
	More Culling: 1.0.6
	ImmediatelyFast: 1.6.6+1.21.1
	AppleSkin: 3.0.5+mc1.21
	Architectury: 13.0.8
	Ferrite Core: 7.0.2
	conditional mixin: 0.6.4
	TRansition: 1.0.3
	Forgified Fabric Rendering Data Attachment (v1): 0.3.48+73761d2e19
	BetterF3: 11.0.3
	Colorwheel: 0.2.3+mc1.21.1
	Jade Addons: 6.1.0+neoforge
	Concurrent Chunk Management Engine (Rewrites/Chunk IO): 0.3.0+alpha.0.71+1.21.1
	ShulkerBoxTooltip: 5.1.6+1.21.1
	Create: Enchantment Industry: 2.1.7
	Concurrent Chunk Management Engine (Optimizations/Memory Allocations): 0.3.0+alpha.0.71+1.21.1
	Create Slice & Dice: 0.0.0-dev
	Vanillin: 1.1.3

[fabien-gigante]

I guess the initial intent of applying different transforms to the vertices and the normals was to preserve some sort of face shading on the rendered icon despite the flattening.

A simple fix to the backface culling problem could be to give up on this feature, and simply apply the squishing transform consistently :

public class ValueBoxRenderer {
	public static void renderFlatItemIntoValueBox(ItemStack filter, PoseStack ms, MultiBufferSource buffer, int light, int overlay) {
		if (filter.isEmpty()) return;
		TransformStack.of(ms)
			.translate(0, 0, -1 / 4f + 1 / 32f + .001)
			.rotateYDegrees(180)
			.scale(.5f, .5f, 1 / 1024f);
		Minecraft mc = Minecraft.getInstance();
		ItemRenderer itemRenderer = mc.getItemRenderer();
		itemRenderer.renderStatic(filter, ItemDisplayContext.GUI, light, OverlayTexture.NO_OVERLAY, ms, buffer, mc.level, 0);
	}

Maybe not the best solution, but definitely acceptable for me (much better than losing half of the faces) :

[simibubi]

Does this issue happen with just Create in your instance?
A fix is justified either way, but it's still interesting to know if it is caused by a mod interaction.

The main reason for the unusual transformation is to keep decent looking lighting for items displayed on the Blueprint entities. If items on the 6 orientations of blueprints look ok with the changed code, then I'm happy to merge your pr

[fabien-gigante]

Quite possibly an interaction with one of Sodium, EntityCulling, MoreCulling, etc. I wouldn't be surprised if those rendering optimization mods have more aggressive backface culling strategies than vanilla does.

I don't know for sure, but I'll make some dedicated tests and let you know about my findings. I will also post a screenshot of blueprints with my proposal for you to judge if it looks ok.

[fabien-gigante]

Results after more investigations and testings.

I think I have found the culprit mod interaction : Flerovium.

Find below the rendering difference between both algorithms (with this Flerovium mod deactivated), illustated on Blueprints, using 6 possible orientations.

• Only Vertices flatten but Normals as if not flatten

• Regular flattening affecting both Vertices and Normals

Not a huge difference in my mind...

This being said, my change proposal only makes Flerovium happy in most cases, but doesn't seem 100% bulletproof. In particular, with items on the ceiling, it still culls some of the faces. I'll investigate more what this Flerovium precisely does.

[fabien-gigante]

Important

With the latest version of Flerovium the problem seems to be fixed !

I'll do more testings, and if confirmed, I'll update my PR accordingly, reverting to vertex only transform.

[fabien-gigante]

PR updated.