Filter display items (visual glich)

[QuicksilverBou]

Description

Some item (fence gate) placed in filter doesen't display on it.

Game Log

https://mclo.gs/XHJpoJD

Debug Information

Client Info

Create:
	Mod Version: 6.0.4
	Mod Git Commit: 254bb816aee1c056c74b2ad4beb88222a499da78
	Ponder Version: 1.0.52
	Forge Version: 47.4.1
	Minecraft Version: 1.20.1

Graphics:
	Flywheel Version: 1.0.2
	Flywheel Backend: flywheel:indirect
	OpenGL Renderer: NVIDIA GeForce GTX 1050/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 555.85
	Graphics Mode: Fancy

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.15, Microsoft
	JVM Flags: 22 total; -Xms2048M -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:MaxGCPauseMillis=200 -XX:+AlwaysPreTouch -XX:+ParallelRefProcEnabled -XX:+UseG1GC -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8M -XX:G1ReservePercent=20 -XX:InitiatingHeapOccupancyPercent=15 -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:+UseStringDeduplication -XX:MaxTenuringThreshold=1 -XX:SurvivorRatio=32 -Xmx8192M -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss2M
	Memory: 1510263400 bytes (1440 MiB) / 4756340736 bytes (4536 MiB) up to 8589934592 bytes (8192 MiB)
	Total Memory: 3254045024 bytes (3103 MiB) / 4756340736 bytes (4536 MiB)
	CPU: AMD Ryzen 7 3700X 8-Core Processor @ 3.59 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics card #0: Parsec Virtual Display Adapter (Parsec Cloud, Inc.); 0.00 MB of VRAM
	Graphics card #1: NVIDIA GeForce GTX 1050 (NVIDIA (0x10de)); 2048.00 MB of VRAM

Other Mods:
	SmartBrainLib: 1.15
	Create ore excavation+: 0.2.3
	Create: Enhanced Mastery: 1.0.0
	ProjectRed Integration: 4.21.0
	YUNG's Better Dungeons: 1.20-Forge-4.0.4
	Mowzie's Mobs: 1.7.3
	YUNG's Better Witch Huts: 1.20-Forge-3.0.3
	FTB Library: 2001.2.9
	GeckoLib 4: 4.7.1.2
	Player Animator: 1.0.2-rc1+1.20
	Create: Copycats+: 3.0.0+mc.1.20.1-forge
	Botarium: 2.3.4
	Create: Gunsmithing: 1.1.2
	Just Enough Items: 15.20.0.112
	Create: Netherless: 1.3.0
	YUNG's Better Ocean Monuments: 1.20-Forge-3.0.4
	Caelus API: 3.1.0+1.20
	Sophisticated Core: 1.2.69.1005
	Kobolds: 2.12.0
	Create Jetpack: 4.4.2
	NukaTeam's Gun Lib: 1.20.1-1.9.3
	ProjectRed Transmission: 4.21.0
	Journeymap: 5.10.3
	CBMultipart Minecraft: 3.3.0.146
	YUNG's API: 1.20-Forge-4.0.6
	UnlimitedPeripheralWorks: 1.5.1
	Customizable Player Models: 0.6.22a
	Create: Central Kitchen: 1.4.1
	MixinExtras: 0.2.0
	More Peripherals: 1.13.0
	Tweakium: 1.0.0
	Create Bitterballen: 1.0
	Sophisticated Backpacks: 3.23.19.1251
	Create: Escalated: 1.0.4
	YUNG's Better Desert Temples: 1.20-Forge-3.0.3
	Farmer's Delight Compat: 1.1.1
	Create: New Age: 1.1.4
	Distant Horizons: 2.3.2-b
	AzureLib: 3.0.7
	Molten Metals: 1.20.1-0.1.4
	Create: Interiors: 0.5.6
	YUNG's Better Nether Fortresses: 1.20-Forge-2.0.6
	FTB Teams: 2001.3.1
	Create: The Factory Must Grow: 0.9.3-1.20.1
	Create: Connected: 1.1.4-mc1.20.1
	Farmer's Delight: 1.20.1-1.2.8
	Computer Craft: Recrafted: 1.20.1-0.5.1.j-55-0.0.3
	Create: Occult Engineering: 0.8.1
	DragonLib: 1.20.1-2.2.24
	Moonlight Library: 1.20-2.14.1
	FTB Quests: 2001.4.13
	Create Ore Excavation: 1.6.3
	ProjectRed Core: 4.21.0
	Create: CC Total Logistics: 0.3.5
	CBMultipart: 3.3.0.146
	Kotlin For Forge: 4.11.0
	CBMicroblock: 3.3.0.146
	Curios API: 5.14.1+1.20.1
	Malum: 1.20.1-1.6.7
	Storage Drawers: 12.9.14
	ProjectRed Fabrication: 4.21.0
	Iron's Spells 'n Spellbooks: 1.20.1-3.4.0.9
	YUNG's Better Strongholds: 1.20-Forge-4.0.3
	Corail Tombstone: 8.9.6
	Turtlematic: 1.4.1
	Broccolium: 1.0.0
	Modonomicon: 1.77.6
	Create Railways Navigator: 1.20.1-beta-0.8.0-C6
	Architectury: 9.1.12
	CC: Tweaked: 1.115.1
	Occultism: 1.141.4
	YUNG's Better End Island: 1.20-Forge-2.0.6
	Create: Power Loader: 2.0.3-mc1.20.1
	Flight Lib: 2.1.0
	Framework: 0.7.15
	Lodestone: 1.20.1-1.6.4.1
	Peripheralium: 1.0.0
	CodeChicken Lib: 4.4.0.516
	YUNG's Better Mineshafts: 1.20-Forge-4.0.4
	Create Teleporters: 2.2
	Create Enchantment Industry: 1.3.2-for-create-6.0.4
	Create Crafts & Additions: 1.20.1-1.3.1
	YUNG's Better Jungle Temples: 1.20-Forge-2.0.5

Server Info

Create:
	Mod Version: 6.0.4
	Mod Git Commit: 254bb816aee1c056c74b2ad4beb88222a499da78
	Ponder Version: 1.0.52
	Forge Version: 47.4.1
	Minecraft Version: 1.20.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.15, Microsoft
	JVM Flags: 22 total; -Xms2048M -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:MaxGCPauseMillis=200 -XX:+AlwaysPreTouch -XX:+ParallelRefProcEnabled -XX:+UseG1GC -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8M -XX:G1ReservePercent=20 -XX:InitiatingHeapOccupancyPercent=15 -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:+UseStringDeduplication -XX:MaxTenuringThreshold=1 -XX:SurvivorRatio=32 -Xmx8192M -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss2M
	Memory: 1510263400 bytes (1440 MiB) / 4756340736 bytes (4536 MiB) up to 8589934592 bytes (8192 MiB)
	Total Memory: 3254045024 bytes (3103 MiB) / 4756340736 bytes (4536 MiB)
	CPU: AMD Ryzen 7 3700X 8-Core Processor @ 3.59 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics card #0: Parsec Virtual Display Adapter (Parsec Cloud, Inc.); 0.00 MB of VRAM
	Graphics card #1: NVIDIA GeForce GTX 1050 (NVIDIA (0x10de)); 2048.00 MB of VRAM

Other Mods:
	SmartBrainLib: 1.15
	Create ore excavation+: 0.2.3
	Create: Enhanced Mastery: 1.0.0
	ProjectRed Integration: 4.21.0
	YUNG's Better Dungeons: 1.20-Forge-4.0.4
	Mowzie's Mobs: 1.7.3
	YUNG's Better Witch Huts: 1.20-Forge-3.0.3
	FTB Library: 2001.2.9
	GeckoLib 4: 4.7.1.2
	Player Animator: 1.0.2-rc1+1.20
	Create: Copycats+: 3.0.0+mc.1.20.1-forge
	Botarium: 2.3.4
	Create: Gunsmithing: 1.1.2
	Just Enough Items: 15.20.0.112
	Create: Netherless: 1.3.0
	YUNG's Better Ocean Monuments: 1.20-Forge-3.0.4
	Caelus API: 3.1.0+1.20
	Sophisticated Core: 1.2.69.1005
	Kobolds: 2.12.0
	Create Jetpack: 4.4.2
	NukaTeam's Gun Lib: 1.20.1-1.9.3
	ProjectRed Transmission: 4.21.0
	Journeymap: 5.10.3
	CBMultipart Minecraft: 3.3.0.146
	YUNG's API: 1.20-Forge-4.0.6
	UnlimitedPeripheralWorks: 1.5.1
	Customizable Player Models: 0.6.22a
	Create: Central Kitchen: 1.4.1
	MixinExtras: 0.2.0
	More Peripherals: 1.13.0
	Tweakium: 1.0.0
	Create Bitterballen: 1.0
	Sophisticated Backpacks: 3.23.19.1251
	Create: Escalated: 1.0.4
	YUNG's Better Desert Temples: 1.20-Forge-3.0.3
	Farmer's Delight Compat: 1.1.1
	Create: New Age: 1.1.4
	Distant Horizons: 2.3.2-b
	AzureLib: 3.0.7
	Molten Metals: 1.20.1-0.1.4
	Create: Interiors: 0.5.6
	YUNG's Better Nether Fortresses: 1.20-Forge-2.0.6
	FTB Teams: 2001.3.1
	Create: The Factory Must Grow: 0.9.3-1.20.1
	Create: Connected: 1.1.4-mc1.20.1
	Farmer's Delight: 1.20.1-1.2.8
	Computer Craft: Recrafted: 1.20.1-0.5.1.j-55-0.0.3
	Create: Occult Engineering: 0.8.1
	DragonLib: 1.20.1-2.2.24
	Moonlight Library: 1.20-2.14.1
	FTB Quests: 2001.4.13
	Create Ore Excavation: 1.6.3
	ProjectRed Core: 4.21.0
	Create: CC Total Logistics: 0.3.5
	CBMultipart: 3.3.0.146
	Kotlin For Forge: 4.11.0
	CBMicroblock: 3.3.0.146
	Curios API: 5.14.1+1.20.1
	Malum: 1.20.1-1.6.7
	Storage Drawers: 12.9.14
	ProjectRed Fabrication: 4.21.0
	Iron's Spells 'n Spellbooks: 1.20.1-3.4.0.9
	YUNG's Better Strongholds: 1.20-Forge-4.0.3
	Corail Tombstone: 8.9.6
	Turtlematic: 1.4.1
	Broccolium: 1.0.0
	Modonomicon: 1.77.6
	Create Railways Navigator: 1.20.1-beta-0.8.0-C6
	Architectury: 9.1.12
	CC: Tweaked: 1.115.1
	Occultism: 1.141.4
	YUNG's Better End Island: 1.20-Forge-2.0.6
	Create: Power Loader: 2.0.3-mc1.20.1
	Flight Lib: 2.1.0
	Framework: 0.7.15
	Lodestone: 1.20.1-1.6.4.1
	Peripheralium: 1.0.0
	CodeChicken Lib: 4.4.0.516
	YUNG's Better Mineshafts: 1.20-Forge-4.0.4
	Create Teleporters: 2.2
	Create Enchantment Industry: 1.3.2-for-create-6.0.4
	Create Crafts & Additions: 1.20.1-1.3.1
	YUNG's Better Jungle Temples: 1.20-Forge-2.0.5

[fabien-gigante]

Proposed Solution

Rather than to continue hardcoding a list of items, I propose to dynamically check the shape thickness instead :

public class ValueBoxRenderer {
   public static void renderItemIntoValueBox(ItemStack filter, PoseStack ms, MultiBufferSource buffer, int light, int overlay) {
      //...
      float zOffset = !blockItem ? -.15f : customZOffset(filter.getItem());
      //...	
   }
   private static float customZOffset(Item item) {
      if (!(item instanceof BlockItem blockItem)) return 0f;
      VoxelShape shape = blockItem.getBlock().defaultBlockState().getShape(null, BlockPos.ZERO);
      if (shape.isEmpty()) return 0f;
      double thickness = shape.max(Direction.Axis.Z) - shape.min(Direction.Axis.Z);
      return thickness <= .25 ? -.1f : 0f;
   }

Resulting rendering with this fix in place, for various thin blocks :

Let me know what you think, and if a PR would be usefull.