Skip to content

Clean up deprecated pseudo-element selectors#17

Merged
planetabhi merged 2 commits intomainfrom
feature
Dec 23, 2025
Merged

Clean up deprecated pseudo-element selectors#17
planetabhi merged 2 commits intomainfrom
feature

Conversation

@planetabhi
Copy link
Member

@planetabhi planetabhi commented Dec 23, 2025

Summary by CodeRabbit

  • Chores

    • Released colors package v2.2.3 and bumped root package to v0.3.4.
  • Style

    • Standardized placeholder styling for more consistent rendering.
    • Removed two obsolete stylelint rules related to unknown pseudo selectors.
  • Documentation

    • Updated README wording for the project description and install note.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

Removed non-standard input-placeholder pseudo selectors from stylelint and SCSS, consolidated to the standard ::placeholder. Bumped packages/colors from 2.2.2→2.2.3 and the root package version from 0.3.3→0.3.4; updated dependency to @new-ui/colors@^2.2.3. Minor README copy changes.

Changes

Cohort / File(s) Summary
Stylelint Configuration
\.stylelintrc\.json
Removed two rules that ignored the non-standard input-placeholder: selector-pseudo-element-no-unknown (ignorePseudoElements) and selector-pseudo-class-no-unknown (ignorePseudoClasses).
SCSS Utilities
packages/colors/src/_utilities.scss
Consolidated placeholder selectors: removed .nu-u-text--placeholder::input-placeholder and .nu-u-text--placeholder:input-placeholder, leaving only .nu-u-text--placeholder::placeholder with the same color value.
Colors package manifest
packages/colors/package.json
Bumped package version 2.2.22.2.3.
Root manifest
package.json
Bumped root package version 0.3.30.3.4 and updated dependency @new-ui/colors from ^2.2.2^2.2.3.
Docs / README
README.md
Minor copy edits: adjusted intro phrasing and an install/docs wording change; no behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the pull request: removing deprecated pseudo-element selectors from stylelint configuration and consolidating placeholder selectors in the SCSS utility file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c95967 and 069ed87.

⛔ Files ignored due to path filters (4)
  • bun.lock is excluded by !**/*.lock
  • dist/index.css is excluded by !**/dist/**
  • dist/index.css.map is excluded by !**/dist/**, !**/*.map
  • packages/colors/dist/index.css is excluded by !**/dist/**
📒 Files selected for processing (2)
  • README.md
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • README.md
🔇 Additional comments (2)
package.json (2)

3-3: LGTM! Appropriate patch version bump.

The version bump from 0.3.3 to 0.3.4 correctly reflects the nature of changes in this PR: cleanup of deprecated selectors, dependency updates, and minor documentation improvements.


60-60: LGTM! Dependency version aligned with package bump.

The dependency update to @new-ui/colors@^2.2.3 correctly reflects the version bump in the colors package, ensuring consistency across the monorepo.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@planetabhi planetabhi changed the title fix Clean up deprecated pseudo-element selectors Dec 23, 2025
@planetabhi planetabhi merged commit 140dc85 into main Dec 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant