Add memory & conn collector, collector manager, tests #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #460 +/- ##
===========================================
- Coverage 90.72% 90.65% -0.08%
===========================================
Files 60 65 +5
Lines 3818 4494 +676
===========================================
+ Hits 3464 4074 +610
- Misses 354 420 +66
|
ankona
force-pushed
the
612
branch
5 times, most recently
from
b6198a4 to
85a303a
Compare
MattToast
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Okay! Still making my way through this PR, but so far looks very impressive. I commented on a lot of the "low hanging fruit" so you at least have something to go off of while you're sorting out why the CI is failing!
I promise to have a more complete review your way ASAP!!
al-rigazzi
reviewed
Feb 2, 2024
MattToast
requested changes
Feb 5, 2024
MattToast
added a commit
to MattToast/SmartSim
that referenced
this pull request
Feb 7, 2024
Sets the default value of the "enable telemetry" flag to on. Currently this will enable telemetry system wide until finer grain control can be established with CrayLabs#460
3 tasks
ashao
requested changes
Feb 7, 2024
MattToast
added a commit
that referenced
this pull request
Feb 7, 2024
This PR makes several patch changes to prepare for a SmartSim release including: - Set the default value of the "enable telemetry" flag to on. Currently this will enable telemetry system wide until finer grain control can be established with #460 - Bump the output `manifest.json` version number to match that of `smartdashboard` - Pin a watchdog version to avoid build errors [ committed by @MattToast @ankona ] [ reviewed by @ankona ] --------- Co-authored-by: Christopher McBride <christopher.mcbride@gmail.com>
This was referenced Feb 9, 2024
mellis13
reviewed
Mar 15, 2024
MattToast
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
CollectorManager. Metrics are written using the newFileSinkclassIncluded collectors:
DbMemoryCollectorDbConnectionCollectorUpdated features
smartsim._core.utils.telemetry.