Skip to content

Commit

Permalink
fix refactor mistakes
Browse files Browse the repository at this point in the history
  • Loading branch information
ankona committed Feb 22, 2024
1 parent cd12d30 commit d8aa972
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion smartsim/_core/entrypoints/telemetrymonitor.py
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,6 @@ def get_parser() -> argparse.ArgumentParser:
parser = get_parser()
args = parser.parse_args()

# log = logging.getLogger(f"{__name__}.TelemetryMonitor")
logger.setLevel(logging.DEBUG)
logger.propagate = False

Expand Down
2 changes: 1 addition & 1 deletion tests/test_collectors.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ async def test_dbconncollector_integration(mock_entity, local_db):
output data matches expectations and proper db client API uage"""
entity = mock_entity(port=local_db.ports[0])

collector = DbConnectionCollector(entity)
collector = DbConnectionCollector(entity, LogSink())

await collector.prepare()
await collector.collect()
Expand Down
4 changes: 2 additions & 2 deletions tests/test_telemetry_monitor.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ def is_alive(self) -> bool:
duration = 2

ts0 = get_ts()
event_loop(observer, mani_handler, frequency, logger, cooldown_duration=duration)
event_loop(observer, mani_handler, frequency, duration)
ts1 = get_ts()

assert ts1 - ts0 >= duration
Expand All @@ -423,7 +423,7 @@ def is_alive(self) -> bool:
duration = 5

ts0 = get_ts()
event_loop(observer, mani_handler, frequency, logger, cooldown_duration=duration)
event_loop(observer, mani_handler, frequency, duration)
ts1 = get_ts()

assert ts1 - ts0 >= duration
Expand Down

0 comments on commit d8aa972

Please sign in to comment.