CASMTRIAGE-7420 Fix kdump hook boot failure #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the default/assumed overlayFS FSLabel. The assumed label was triggering code, like `metal-kdump.sh`, to run when it shouldn't (as the case with CASMTRIAGE-7420, when no overlayFS was given). This change adds an early exit to `metal-kdump.sh` for boots without overlays.
jpdavis-prof
approved these changes
Oct 21, 2024
Along the same theme as the previous commit, remove the chance for code to run against non-existent drive labels by removing the default/assumed labels. Tidies up the cases for SQFSRAID; adds a blank case for safely loading `metal-md-lib.sh` where `root` is something else, and prints messages similar to the `oval_drive_scheme` case. This also fixes a hidden bug on line 87 of `metal-md-lib.sh`, this line should be only overriding `SQFS_DRIVE_SCHEME` if it is equal to `CDLABEL` but the `||` was doing the opposite of that.
rustydb
force-pushed
the
CASMTRIAGE-7420
branch
from
5e47875
to
c3d0519
Compare
rustydb
commented
Oct 21, 2024
|
Using surtur for a remoteISO test. |
`metal-kdump.sh` was recreating some of the logic in `metal-md-lib.sh` for resolving the overlayFS scheme and authority. Short of sourcing `metal-md-lib.sh`, it would bode well if we parsed the scheme and authority every boot and only once. By moving the scheme and authority parsing out of `metal-md-lib.sh`, the parsing will occur once and at the beginning of the boot instead of every time `metal-md-lib.sh` is sourced. Additionally, this removes the `exit` calls from `metal-md-lib.sh`. Libraries shouldn't exit.
rustydb
force-pushed
the
CASMTRIAGE-7420
branch
from
c3d0519
to
fe70b53
Compare
`MOUNT_OVERLAYfs_id` should be all lowercase, it was recently awkward cased in a previous, greedy string replace operation. There is also no point in checking if `metal_overlayfs_id` is empty, it will always be empty until we set it. We want this variable to always be fresh, it should always recalculate when the function is ran later.
rustydb
force-pushed
the
CASMTRIAGE-7420
branch
from
fe70b53
to
cb2e704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Issue Type
Fixes issues when booting without an overlayFS.
Removes fallback assumptions around FSLabels that were causing code to run in undesirable cases.
Prerequisites
Idempotency
Risks and Mitigations
Successfully tested deploying and rebooting:
Successfully triggered a crash on: