-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMTRIAGE-7175: Handling sat image path update during 1.5 to 1.6 upgrade #5402
Conversation
ab318b3
to
acf6ce4
Compare
c297636
to
ef58b05
Compare
During the unstable RPM testing, identified another issue, were the get_filenames_referring_to_image was trying to grep for the file with the new THIS_IMAGE value passed from the update_cray_sat_image as. the condition was met. But since the yaml file is reflected for to the IMAGE value of "artifactory.algol60.net/csm-docker/stable/cray-sat". Hence the function is updated to handle the yaml file fetch were the tag needs to be updated. Tested on drax system with 1.5 Output before the latest changes:ncn-m001:/mnt/developer/shiva # rpm -ivh docs-csm-1.6.99 Output After the latest changes:ncn-m001:/mnt/developer/shiva # rpm -ivh docs-csm-1.6.99 |
ef58b05
to
a843e25
Compare
Although Shiva's testing output shows this:
It does not actually update the version of the The file specifies the |
IM:CASMTRIAGE-7175
Description
During the csm upgrade from 1.5 to 1.6, when the docs-csm rpm is installed before the 1.6 assets getting loaded. Due to which the sat tag pull up fails, since the new path(artifactory.algol60.net/csm-docker/stable/cray-sat) is not available on the system yet. Hence to handle the scenario, if the image doesnot exist for the default path. A function is created to verify and provide the alternative image path(artifactory.algol60.net/sat-docker/stable/cray-sat)Test Description
The scenario was recreated on starlord system. The script was executed to verify the update of the tag. It was able to update the tag with picking up the alternative path for SAT.
ncn-m001:/usr/share/doc/csm/workflows # ./update_tags.sh
Outside loop:
3.32.0
Updating tag of artifactory.algol60.net/sat-docker/stable/cray-sat in /usr/share/doc/csm/workflows/./templates/base/sat-general-iuf.template.argo.yaml to 3.32.0.
ncn-m001:/usr/share/doc/csm/workflows #
Checklist
.github/CODEOWNERS
with the corresponding team in Cray-HPE.