forked from fluent/fluent-bit
-
Notifications
You must be signed in to change notification settings - Fork 0
New Network Verifier plugin type #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
add flb_network_verifier.c and include openssl header directories Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
pass through the network_verifier instance to TLS context creation and onto openssl, if non NULL will retrieve the verify callback function from the plugin and assign to the SSL_CTX_verify_callback. Also adds the network_verifier instance as a X509_STORE data variable so it is accessible for the callback function to use. Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…ate function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…te function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…e function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…nction Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
… function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…te function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…create function Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…unction Signed-off-by: Craig Robb <craig.robb@gallagher.com>
start / shutdown Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
…tify of network errors Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Signed-off-by: Craig Robb <craig.robb@gallagher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to allow for more custom TLS verification by creating a new network_verifier plugin, with the ability to define the OpenSSL callback for the SSL_CTX_set_verify function. If a plugin is configured to use TLS, and has an assigned network_verifier, during the creation of the TLS connection the assigned network_verifier callback function will be set to the OpenSSL's SSL_CTX.
During the TLS connection handshake, OpenSSL will call on the callback function, allowing Fluent Bit to have more custom control for verification with access to this callback. The network_verifier callback will only be called if tls.verify is on
This allows for external network_verifier plugins to be loaded in the plugins section of a yaml conf following the existing format for external plugins, for a network_verifier it it expected to be in the file name format flb-network_verifier_.so
Added the ability to inform a Network Verifier plugin of connection issues when attempting to connect to an Endpoint. This will allow custom external handling of these error conditions.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.