Small fixes #73
Open
Small fixes #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are TCP timeouts, but in situations where it fails instantly there would otherwise be no delay. (E.g. firewall rejection, or when in flight mode.)
This change only makes it work when in offline/airplane mode. When connected to a server it still crashes. Likely due to a different part of the code. Thanks to https://github.com/piplup55 for pointing out to me that this worked in old versions. I then tested a few older builds and found out that it started to not work with version `v1.1.0`. Using `git bisect` I was able to find out that commit 34691af introduced the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.