Improve and simplify the debug menu #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Istador
commented
May 29, 2024
•
Istador
commented
- Simplify and rearrange it so that it can be better understood by non-developers:
- 9d0bcdf
- 113b4dc
- 0ae976f
- 888dd72
- 06c75a2
- 45306e1
- 4af309b
- 144b5d2
- 48b137f
- 7bdea23
- Add additional infos that makes debugging easier (server IP & port, mod version).
- 8ce8569
- 5769779
- Also changing the mod menu:
- 75aa297
- d46b55e
- Show how much is used instead of how much is free. - Double precision, because of observable inaccuracies otherwise. - Divide by 1024 instead of by 1000 to display KiB instead of KB. - Show only one fractional digit. - (The max is exactly 320 KiB, so need to show a fractional digit for it.)
fallback to git info if not builded for a specific version
- Show `Yes` and `No` instead of `True` and `False` - Remove `Is in Capture` - Always show `Capture` - Combine `Animation Index` and `Packet Animation` into one `Animation` line - Rename `Puppet0` to `Empty Slot 1` - Don't mention puppets
- title - code indentation - X Y Z alignment for position and rotation
…rst line The socket needs its own copy of the IP, otherwise it wrongly changes the displayed server after changing it in the mod menu.
- Client.hpp: add bool variable and methods - hooks.cpp: save/load value from common.bin - main.cpp: change - StageSceneStateServerConfig: add button to the mod menu to toggle it
…equires a restart Also: call it `server address` instead of `server IP`, because domains work too.
|
Rebased to solve merge conflicts with #65 in:
|
2 warnings found (use --debug to expand): - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1) - JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signals (line 13)
Also: - remove unused `L + Right` and `L + Up` controls for debug puppets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.